CSPL-3775 extract common code in tests (#1788)

* Feature/CSPL-4397 Eliminate reliance on time in tests (#1735)

* CSPL-4397 Remove time dependency from tests

* CSPL-4397 Removing test reliance on time

* CSPL-4397 Adjusting timeouts

* CSPL-4354 Fixing time dependencies in unit tests and fixing timeouts in integ tests

* CSPL-4397 Move to using watch

* CSPL-4397 Refactor pod reset detection to use UID-based tracking instead of time-based comparison, add fail-fast test prerequisites validation, and improve code clarity with variable renaming

* CSPL-4397 Refactoring

* CSPL-4397 Addressing comments

* CSPL-4602 Moving duplicated code for LM tests to a shared codebase (#1768)

* CSPL-4602 Moving duplicated code for LM tests to a shared codebase

* CSPL-4602 Addinf license manager tests to workflows

* CSPL-4602 Address comments

* CSPL-4602 Moving LM shared test utils to licensemanager package

* CSPL-4602 Addressing base branch changes

* Feature/cspl 4377 remove panic from test (#1777)

* CSPL-4377 Get rid of not expected panic in tests

* CSPL-4377 Check error for app disablement in tests

* CSPL-3775 Extract setup/teardown functions

* CSPL-3775 Extract common code for secret tests

* CSPL-3775 Extract CRUD common code

* CSPL-3775 Extract common code for smartstore tests

* CSPL-3775 Combining code into re-usable functions

* CSPL-3775 Fix pipeline issues after the changes

* CSPL-3775 Refactoring app fw tests to use before each and after each  code

* CSPL-3775 Extracting common constants

* CSPL-3775 Ingest functions

* CSPL-3775 Move verify prerequisites to setup

* CSPL-3775 Remove constants that already exist

* CSPL-3775 Standardizing suite_test.go

* CSPL-3775 Remove unused functions

* CSPL-3775 Replcaing duplicates among different tests

* CSPL-3775 Eliminating duplicated v3/v4 branching logic

* CSPL-3775 Each test case delegates to a shared Run*Test function, keeping the test file as a thin dispatch layer

* CSPL-3775 Standardize test code by fixing typos in log messages/comments, removing duplicate helpers, replacing inline logic with shared utilities

* CSPL-3775 Consistency improvements

* Fix Silent Failures  (#1785)

* Enhance error handling in WaitforPhaseChange and fix variable name in NewTestCaseEnv

* Updated WaitforPhaseChange to log an error if the phase transition is not observed within the timeout.
* Corrected the variable name check in NewTestCaseEnv to use the provided name instead of an uninitialized envName.
* Changed Kind from "ClusterManager" to "ClusterMaster" in ClusterMaster struct.

* Update error logging in WaitforPhaseChange to use Error level for timeout observations

* CSPL-3775 Refactoring - common naming, format and making sure functinality is not malformed

* CSPL-3775 Eliminate duplicated verification patterns, fix redundant code, and standardize naming, godoc comments, and constants for consistency

* CSPL-3775 Reorganizing utils

* CSPL-3775 Removing gomega/ginkgo from utils

* CSPL-3775 Addressing timeout comments

* CSPL-3775 Fix test failures

* CSPL-3665 Fix License Manager tests

* CSPL-3775 Removing duplicates

* CSPL-3775 Move assertions out of helper functions

* CSPL-3775 Remove redundant inputs

* CSPL-3775 Final polishing to remove duplicates and make codebase more consistent

* CSPL-3775 Restoring accidentally removed test cases

* CSPL-3775 Making some improvements

* CSPL-3775 Adjust timeouts

* CSPL-4378 Adding timeout to app fw verification

* CSPL-4378 Fix failing managersmartstore test

* CSPL-3775 Revert changes that only match v3, skipped for v4

* CSPL-3775 Restoring backward compatibility

* CSPL-3775 Add missing assertions

* CSPL-3775 Add missing assertions

* CSPL-3775 Fixing manager smart store tests

* CSPL-3775 Increase timeout for app fw

* CSPL-3775 Adjust timeouts

* CSPL-3775 Increasing timeouts

* CSPL-3775 Fix introduced backward incompatibility

* CSPL-3775 Fix failing helm tests

---------

Co-authored-by: Jakub Buczak <jbuczak@splunk.com>

Author: kasiakoziol

.github/workflows/arm-AL2023-build-test-push-workflow-AL2023.yml

@@ -135,7 +135,7 @@ jobs:
                 appframeworksS1,
                 managersecret,
                 managermc,
-                indingsep,
+                indexingestionsep,
                 licensemanager,
                ]
     runs-on: ubuntu-latest

.github/workflows/arm-AL2023-int-test-workflow.yml

@@ -69,7 +69,7 @@ jobs:
             managercrcrud,
             licensemanager,
             managerdeletecr,
-            indingsep,
+            indexingestionsep,
           ]
     runs-on: ubuntu-latest
     needs: build-operator-image-arm-al2023

.github/workflows/arm-RHEL-build-test-push-workflow.yml

@@ -69,7 +69,7 @@ jobs:
             managercrcrud,
             licensemanager,
             managerdeletecr,
-            indingsep,
+            indexingestionsep,
           ]
     runs-on: ubuntu-latest
     needs: build-operator-image-arm-rhel

.github/workflows/arm-RHEL-int-test-workflow.yml

@@ -69,7 +69,7 @@ jobs:
             managercrcrud,
             licensemanager,
             managerdeletecr,
-            indingsep,
+            indexingestionsep,
           ]
     runs-on: ubuntu-latest
     needs: build-operator-image-arm-rhel

.github/workflows/arm-Ubuntu-build-test-push-workflow.yml

@@ -135,7 +135,7 @@ jobs:
                 appframeworksS1,
                 managersecret,
                 managermc,
-                indingsep,
+                indexingestionsep,
                 licensemanager,
               ]
     runs-on: ubuntu-latest

.github/workflows/arm-Ubuntu-int-test-workflow.yml

@@ -69,7 +69,7 @@ jobs:
             managercrcrud,
             licensemanager,
             managerdeletecr,
-            indingsep,
+            indexingestionsep,
           ]
     runs-on: ubuntu-latest
     needs: build-operator-image-arm-ubuntu

.github/workflows/build-test-push-workflow.yml

@@ -218,7 +218,7 @@ jobs:
                 managerappframeworkm4,
                 managersecret,
                 managermc,
-                indingsep,
+                indexingestionsep,
                 licensemanager,
                ]
     runs-on: ubuntu-latest

.github/workflows/distroless-build-test-push-workflow.yml

@@ -194,7 +194,7 @@ jobs:
           managerappframeworkm4,
           managersecret,
           managermc,
-          indingsep,
+          indexingestionsep,
           licensemanager,
         ]
     runs-on: ubuntu-latest

.github/workflows/distroless-int-test-workflow.yml

@@ -73,7 +73,7 @@ jobs:
             managercrcrud,
             licensemanager,
             managerdeletecr,
-            indingsep,
+            indexingestionsep,
           ]
     runs-on: ubuntu-latest
     needs: build-operator-image-distroless

.github/workflows/int-test-workflow.yml

@@ -70,7 +70,7 @@ jobs:
             managercrcrud,
             licensemanager,
             managerdeletecr,
-            indingsep,
+            indexingestionsep,
           ]
     runs-on: ubuntu-latest
     needs: build-operator-image