remove space and newline checks

Author: minjieqiu

pkg/splunk/util/util.go

@@ -173,25 +173,6 @@ func ValidateSecret(tokenValue []byte) error {
 		return fmt.Errorf("secret is empty")
 	}
 
-	secretStr := string(tokenValue)
-
-	// Check for leading or trailing whitespace
-	if secretStr != strings.TrimSpace(secretStr) {
-		return fmt.Errorf("secret has leading or trailing whitespace")
-	}
-
-	// Check for newlines
-	if strings.Contains(secretStr, "\n") || strings.Contains(secretStr, "\r") {
-		return fmt.Errorf("secret contains newlines")
-	}
-
-	// Check for control characters (ASCII 0-31 and 127)
-	for _, ch := range secretStr {
-		if ch < 32 || ch == 127 {
-			return fmt.Errorf("secret contains control characters")
-		}
-	}
-
 	// Minimum length for secrets (at least 12 characters)
 	const minLength = 12
 	if len(tokenValue) < minLength {

pkg/splunk/util/util_test.go

@@ -480,36 +480,6 @@ func TestValidateSecret(t *testing.T) {
 			tokenVal:  []byte("12345678901"),
 			wantError: true,
 		},
-		{
-			name:      "secret with leading whitespace",
-			tokenVal:  []byte(" 123456789012"),
-			wantError: true,
-		},
-		{
-			name:      "secret with trailing whitespace",
-			tokenVal:  []byte("123456789012 "),
-			wantError: true,
-		},
-		{
-			name:      "secret with newline",
-			tokenVal:  []byte("12345678901\n23"),
-			wantError: true,
-		},
-		{
-			name:      "secret with carriage return",
-			tokenVal:  []byte("12345678901\r23"),
-			wantError: true,
-		},
-		{
-			name:      "secret with control character (tab)",
-			tokenVal:  []byte("12345678901\t23"),
-			wantError: true,
-		},
-		{
-			name:      "secret with null character",
-			tokenVal:  []byte("12345678901\x0023"),
-			wantError: true,
-		},
 	}
 
 	for _, tt := range tests {