Skip to content

Commit 569574c

Browse files
committed
Review Feedback Vol. 1
1 parent ca3745f commit 569574c

2 files changed

Lines changed: 20 additions & 29 deletions

File tree

docs/extensions.adoc

Lines changed: 11 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -787,25 +787,21 @@ tasks.named("test", Test) {
787787
== Third-Party Extensions
788788

789789
You can find a list with some third-party extensions in the https://github.com/spockframework/spock/wiki/Third-Party-Extensions[Spock Wiki].
790-
This list is neither maintained nor curated by the Spock maintainers. It is also not necessarily complete, so you might
791-
find further Spock extensions through web searches or other means. It is a community-driven page where
792-
anyone can list Spock extensions they wrote or found.
790+
This list is neither maintained nor curated by the Spock maintainers.
791+
It is also not necessarily complete, so you might find further Spock extensions through web searches or other means.
792+
It is a community-driven page where anyone can list Spock extensions they wrote or found.
793793

794794
[NOTE]
795795
--
796796
JUnit Jupiter is a separate test engine also running on JUnit Platform and thus is a sibling of the Spock engine.
797-
Extensions written for JUnit Jupiter do _not_ work in Spock specifications out of the box. Often terms are mixed up and
798-
some extension says it is for JUnit 5+, actually meaning it is for JUnit Jupiter, as there are no generic JUnit Platform
799-
extensions. If you want to use an extension written for JUnit Jupiter, you can check whether the project also provides
800-
a Spock extension, if not ask them to also provide a Spock extension, search for an alternative extension that supports
801-
Spock, or port the Jupiter extension to being a Spock extension yourself.
802-
803-
There is also at least one 3rd party extension that as of this writing provides a partly functioning integration of
804-
JUnit Jupiter extensions within Spock specifications. This extension though is neither maintained, nor recommended,
805-
nor discouraged by the Spock maintainers. It can eventually make some JUnit Jupiter extensions work within Spock specifications,
806-
but it is always preferable to instead use a native Spock extension. Often porting a JUnit Jupiter extension to also support
807-
Spock is not a big effort, so you might strongly consider to request a port by the extension maintainer or contribute
808-
a port to its project.
797+
Extensions written for JUnit Jupiter do _not_ work in Spock specifications out of the box.
798+
Often terms are mixed up and some extension says it is for JUnit 5+, actually meaning it is for JUnit Jupiter, as there are no generic JUnit Platform extensions.
799+
If you want to use an extension written for JUnit Jupiter, you can check whether the project also provides a Spock extension, if not ask them to also provide a Spock extension, search for an alternative extension that supports Spock, or port the Jupiter extension to being a Spock extension yourself.
800+
801+
There is also at least one 3rd party extension that as of this writing provides a partly functioning integration of JUnit Jupiter extensions within Spock specifications.
802+
This extension though is neither maintained, nor recommended, nor discouraged by the Spock maintainers.
803+
It can eventually make some JUnit Jupiter extensions work within Spock specifications, but it is always preferable to instead use a native Spock extension.
804+
Often porting a JUnit Jupiter extension to also support Spock is not a big effort, so you might strongly consider to request a port by the extension maintainer or contribute a port to its project.
809805
--
810806

811807

docs/spock_primer.adoc

Lines changed: 9 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -854,24 +854,19 @@ activated by annotations called _directives_. Currently, Spock ships - among oth
854854
be resolved immediately. Second, to replace exception conditions in certain corner cases where the latter cannot be
855855
used (like specifying the behavior of exception conditions). In all other cases, exception conditions are preferable.
856856

857-
Go to the <<extensions.adoc#extensions,Extensions>> chapter to learn how to implement your own directives and extensions,
858-
to learn where to find some of the 3rd party extensions, and to learn about all built-in extensions and directives.
857+
Go to the <<extensions.adoc#extensions,Extensions>> chapter to learn how to implement your own directives and extensions, to learn where to find some of the 3rd party extensions, and to learn about all built-in extensions and directives.
859858

860859
[NOTE]
861860
--
862861
JUnit Jupiter is a separate test engine also running on JUnit Platform and thus is a sibling of the Spock engine.
863-
Extensions written for JUnit Jupiter do _not_ work in Spock specifications out of the box. Often terms are mixed up and
864-
some extension says it is for JUnit 5+, actually meaning it is for JUnit Jupiter, as there are no generic JUnit Platform
865-
extensions. If you want to use an extension written for JUnit Jupiter, you can check whether the project also provides
866-
a Spock extension, if not ask them to also provide a Spock extension, search for an alternative extension that supports
867-
Spock, or port the Jupiter extension to being a Spock extension yourself.
868-
869-
There is also at least one 3rd party extension that as of this writing provides a partly functioning integration of
870-
JUnit Jupiter extensions within Spock specifications. This extension though is neither maintained, nor recommended,
871-
nor discouraged by the Spock maintainers. It can eventually make some JUnit Jupiter extensions work within Spock specifications,
872-
but it is always preferable to instead use a native Spock extension. Often porting a JUnit Jupiter extension to also support
873-
Spock is not a big effort, so you might strongly consider to request a port by the extension maintainer or contribute
874-
a port to its project.
862+
Extensions written for JUnit Jupiter do _not_ work in Spock specifications out of the box.
863+
Often terms are mixed up and some extension says it is for JUnit 5+, actually meaning it is for JUnit Jupiter, as there are no generic JUnit Platform extensions.
864+
If you want to use an extension written for JUnit Jupiter, you can check whether the project also provides a Spock extension, if not ask them to also provide a Spock extension, search for an alternative extension that supports Spock, or port the Jupiter extension to being a Spock extension yourself.
865+
866+
There is also at least one 3rd party extension that as of this writing provides a partly functioning integration of JUnit Jupiter extensions within Spock specifications.
867+
This extension though is neither maintained, nor recommended, nor discouraged by the Spock maintainers.
868+
It can eventually make some JUnit Jupiter extensions work within Spock specifications, but it is always preferable to instead use a native Spock extension.
869+
Often porting a JUnit Jupiter extension to also support Spock is not a big effort, so you might strongly consider to request a port by the extension maintainer or contribute a port to its project.
875870
--
876871

877872
== Comparison to JUnit

0 commit comments

Comments
 (0)