Skip to content

Test explicit and implicit call() invocations for pollling conditions#2172

Merged
Vampire merged 2 commits into
masterfrom
vampire/improve-pollingcondition-tests
Oct 28, 2025
Merged

Test explicit and implicit call() invocations for pollling conditions#2172
Vampire merged 2 commits into
masterfrom
vampire/improve-pollingcondition-tests

Conversation

@Vampire
Copy link
Copy Markdown
Member

@Vampire Vampire commented Jun 3, 2025

No description provided.

Copy link
Copy Markdown
Member Author

Vampire commented Jun 3, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.07%. Comparing base (3013685) to head (c98ef35).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2172      +/-   ##
============================================
+ Coverage     82.04%   82.07%   +0.02%     
  Complexity     4754     4754              
============================================
  Files           465      465              
  Lines         14871    14871              
  Branches       1878     1878              
============================================
+ Hits          12201    12205       +4     
+ Misses         1982     1978       -4     
  Partials        688      688              

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Vampire Vampire force-pushed the vampire/improve-pollingcondition-tests branch 3 times, most recently from ce7358d to b3e8a54 Compare June 5, 2025 14:46
@Vampire Vampire force-pushed the vampire/improve-pollingcondition-tests branch from b3e8a54 to 9a62810 Compare August 25, 2025 12:57
@Vampire Vampire force-pushed the vampire/improve-pollingcondition-tests branch from 9a62810 to 3e83a36 Compare October 9, 2025 16:44
@Vampire Vampire force-pushed the vampire/improve-pollingcondition-tests branch 8 times, most recently from d04a0ad to a5b978d Compare October 22, 2025 10:05
@Vampire Vampire modified the milestone: 2.4 Oct 23, 2025
@Vampire Vampire force-pushed the vampire/improve-pollingcondition-tests branch 6 times, most recently from 08ece1a to 40d25da Compare October 24, 2025 14:45
Comment thread spock-specs/src/test/groovy/spock/util/concurrent/PollingConditionsSpec.groovy Outdated
Comment thread spock-specs/src/test/groovy/spock/util/concurrent/PollingConditionsSpec.groovy Outdated
Comment thread spock-specs/src/test/groovy/spock/util/concurrent/PollingConditionsSpec.groovy Outdated
Comment thread spock-specs/src/test/groovy/spock/util/concurrent/PollingConditionsSpec.groovy Outdated
@AndreasTu
Copy link
Copy Markdown
Member

@Vampire Did you maybe forgot to push your changes?

@Vampire
Copy link
Copy Markdown
Member Author

Vampire commented Oct 25, 2025

Forgot to push? No
Already pushed? No
Requested Re review? No
:-)

I tried to re-understand "see PollingConditions javadoc." to know what the problem is, maybe describe it more explicitly, and evaluate whether it needs to be added to all such lines and not only those where you suggested it, then I had to go.

@Vampire Vampire force-pushed the vampire/improve-pollingcondition-tests branch from 40d25da to c371759 Compare October 25, 2025 17:25
@Vampire Vampire requested a review from AndreasTu October 25, 2025 17:25
Copy link
Copy Markdown
Member

@AndreasTu AndreasTu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you!

Copy link
Copy Markdown
Member Author

Vampire commented Oct 28, 2025

Merge activity

  • Oct 28, 4:30 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Oct 28, 4:31 PM UTC: Graphite rebased this pull request as part of a merge.
  • Oct 28, 4:53 PM UTC: Graphite couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'Build and Verify (5.0, 25, ubuntu-latest)').

@Vampire Vampire force-pushed the vampire/improve-pollingcondition-tests branch from c371759 to c98ef35 Compare October 28, 2025 16:30
@Vampire Vampire merged commit ba6df83 into master Oct 28, 2025
140 of 143 checks passed
@Vampire Vampire deleted the vampire/improve-pollingcondition-tests branch October 28, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants