Expand IcebergIO write API to cover all write options#5986
Open
clairemcginty wants to merge 4 commits into
Open
Expand IcebergIO write API to cover all write options#5986clairemcginty wants to merge 4 commits into
clairemcginty wants to merge 4 commits into
Conversation
clairemcginty
commented
Jul 24, 2026
| writeProperties: Map[String, String] = IcebergIO.WriteParam.DefaultWriteProperties, | ||
| sortFields: List[String] = IcebergIO.WriteParam.DefaultSortFields, | ||
| partitionFields: List[String] = IcebergIO.WriteParam.DefaultPartitionFields, | ||
| extraConfigProperties: Map[String, AnyRef] = IcebergIO.WriteParam.DefaultExtraConfigProperties, |
Contributor
Author
There was a problem hiding this comment.
I thought this was more flexible than adding a dedicated named param for every new option added to the Iceberg write api (i.e. distribution_mode, autosharing, etc...)
Contributor
There was a problem hiding this comment.
Yeah might be better this way indeed till the API stabilizes
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5986 +/- ##
=======================================
Coverage 61.99% 61.99%
=======================================
Files 323 323
Lines 11737 11742 +5
Branches 793 829 +36
=======================================
+ Hits 7276 7280 +4
- Misses 4461 4462 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
regadas
approved these changes
Jul 24, 2026
clairemcginty
commented
Jul 24, 2026
| withClue( | ||
| "Iceberg writeProperties are not supported in Beam versions <= 2.76. Once Beam is upgraded, flip this assertion to `true`." | ||
| ) { | ||
| hasBloom shouldBe false |
Contributor
Author
There was a problem hiding this comment.
This won't work until the next Beam release w/ apache/beam#39250 ; I did validate that this test passes when using a locally built Beam snapshot 👍
clairemcginty
marked this pull request as ready for review
July 24, 2026 19:09
regadas
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expands iceberg write API to support
distribution_modeconfigPropertiestowritePropertiesto match Iceberg convention https://iceberg.apache.org/docs/latest/configuration/#write-properties