Album Sync Implementation.#109
Open
BryScordia wants to merge 1 commit into
Open
Conversation
Adding to the main tool an Album Sync Implementation.
|
Tried this out and it successfully synced my collection of 1964 albums! Very nice. Thank you for this :) |
|
The only thing I'd change about this implementation is to iterate the album list in reverse, so that the albums get added in the order they were originally. This makes the order in which they show up match in the "Date added" sorting option, which is the default in both Tidal and Spotify. This is as simple as: diff --git a/src/spotify_to_tidal/sync.py b/src/spotify_to_tidal/sync.py
index f3ca579e85..6ebae0f835 100755
--- a/src/spotify_to_tidal/sync.py
+++ b/src/spotify_to_tidal/sync.py
@@ -450,6 +450,9 @@
print("Loading albums from Spotify")
spotify_albums = await get_albums_from_spotify(spotify_session)
+ # Reverse the albums to match the order in which the user added it.
+ # That is, the first liked album should be inserted first.
+ spotify_albums.reverse()
print(f"Found {len(spotify_albums)} albums to sync") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding to the main tool an Album Sync Implementation.