Various improvements

[joshrmcdaniel]

This is currently a WIP, theres a couple of things TODO:

• hide 429 log message
• improve searching further
• update docs
• remove redundant functions

 
New features:

• Caching is now a singleton, all songs retrieved in all playlists will be cached during run.
• Significantly improved runtime
• Only run process map on results not cached
• CLI package
• tidalapi to 0.7.2
• Add logging
• Searching now uses casefold instead of lower, to better check title equality
• Searching now uses all spotify artists (if multiple artists specified in Spotify)
• Refactor
• Type hint
• Most YAML file attributes can be specified on the CLI
• Various other improvements

[RobinHirst11]

fuckin great, although i've had a few issues i would like to resolve with you

[timrae]

Hey @joshrmcdaniel thanks for the PR it looks good but it's quite a lot of changes for me to review and I'm not really able to put much time into this project. Would you be interested in taking over maintenance of this project?

[RobinHirst11]

heya @joshrmcdaniel, i made some ajustments which may be useful for you to look at, namely:
sync.txt

clearing the teriminl after each playlist

• print("\033[2J\033[H", end="", flush=True)

"fixing" the ratelimit

• tidal_tracks = call_async_with_progress(tidal_search, spotify_tracks, task_description, config.get('subprocesses', 10), tidal_session=tidal_session)

if you have discord, that would be a lot better to collaborate on this :)

[joshrmcdaniel]

I can take a look at doing fixes this weekend @RobinHirst11

I don't mind taking over in regards to maintenance either @timrae

[timrae]

It would be great to add some unit test cases for the matching algorithm. I'm a bit scared to change anything atm as there are no tests and I went to some effort to optimize the match rate. Unit tests would help to prevent regressions in the match rate.

[timrae]

Could you please split this into separate PRs? The first PR should be non-functional refactoring changes, and subsequent PRs should have functional changes. Currently it's very difficult to see what has been changed, particularly in the main sync file.

[timrae]

Would be great to incorporate some of these changes if you can pull them out into smaller PRs once #43 is merged

[timrae]

@joshrmcdaniel Please email me if you're still interested in helping out with maintenance. You can find my email in the git history.