feat: allow scoped spreadsheet imports#2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1 by adding an opt-in scope for spreadsheet imports.
@spreadsheetimporter.enabledon CDS entities and service projections.403 SPREADSHEET_IMPORT_ENTITY_NOT_ENABLEDbefore reading/parsing the upload stream.Spreadsheet(entity='my.bookshop.Books')/contentkeep working.Booksviacds.entities()while using compiled model definitions for projection/source resolution.@requiresor@restrict.Root Cause
The importer previously trusted the
entityURL parameter, resolved it directly from the CAP entity lookup, and inserted throughcds.db. That bypassed normal service-level restrictions such as@readonlyon exposed service entities, so there was no way to enable the importer for only selected entities.CAP Practice Applied
@requiresand@restrictannotations instead of being reimplemented in the importer.req.reject(...), which CAP documents as the preferred request rejection path.cds.test(...).in(...)so CAP test servers are isolated and no external localhost server is required.Validation
node -c importer-service.jsgit diff --checknpm test -- --runInBand— 3 suites, 12 tests passing