feat: add SkillProvider SPI for pluggable skill backends#36
Open
danielvolovik96 wants to merge 1 commit into
Open
feat: add SkillProvider SPI for pluggable skill backends#36danielvolovik96 wants to merge 1 commit into
danielvolovik96 wants to merge 1 commit into
Conversation
* Add SkillProvider and SkillDescriptor interfaces in common module * Create FileSystemSkillProvider as default implementation * Refactor SkillsFunction to delegate to providers at invocation time * Add addSkillProvider() to SkillsTool.Builder * Full backward compatibility with existing addSkillsDirectory/Resource API
|
Hi, this PR would directly help our use case. We need skills to be managed through an admin UI, eventually stored in a database, and selected dynamically depending on the current project/context. Users may work on different projects or domains, each requiring a different set of skills, so a static filesystem or classpath-backed source does not fit well. The proposed A quick review would definitely help ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #37
Summary
SkillProviderandSkillDescriptorinterfaces in the common module as a Service Provider Interface for pluggable skill backendsFileSystemSkillProvideras the default implementation (refactored from existing logic)SkillsFunctionto delegate to providers at invocation timeaddSkillProvider()toSkillsTool.BuilderaddSkillsDirectory/ResourceAPITest plan
FileSystemSkillProviderSkillsToolwith provider integration