Add tool governance advisors and reasoning trace observability#42
Open
vaquarkhan wants to merge 2 commits into
Open
Add tool governance advisors and reasoning trace observability#42vaquarkhan wants to merge 2 commits into
vaquarkhan wants to merge 2 commits into
Conversation
Introduce a standalone advisor that wraps tool callbacks and applies allow/deny/rewrite policy decisions before tool execution, with tests and documentation for integration.
Add ToolApprovalAdvisor, ToolArgumentValidationAdvisor, ToolTimeoutAdvisor, ToolRateLimitAdvisor, ToolFilterAdvisor, and ReasoningTraceAdvisor with tests and docs, and update README advisor listings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a set of standalone ChatClient advisors for tool governance and loop observability in spring-ai-agent-utils:
ToolCallPolicyAdvisorfor allow/deny/rewrite decisions before tool execution.ToolApprovalAdvisorfor human-in-the-loop approvals usingCompletableFutureblocking.ToolArgumentValidationAdvisorfor tool argument byte-size limits.ToolTimeoutAdvisorfor per-tool timeout enforcement (with default + overrides).ToolRateLimitAdvisorfor per-request (loop) tool call rate limiting.ToolFilterAdvisorfor include/exclude filtering by glob-style tool name patterns.ReasoningTraceAdvisorfor per-iteration trace emission with timing and tool-call metadata.Additional changes:
spring-ai-agent-utils/docs.spring-ai-agent-utils/README.mdadvisor section to include all new advisors.Why
These advisors provide missing governance and observability controls commonly needed in production agent systems:
Test Plan
-- Result: all tests passed (
15tests,0failures).Command used: