Fix missing dependency version during mvn verify, put shared example dependencies to parent#48
Open
mvlcak wants to merge 2 commits into
Open
Fix missing dependency version during mvn verify, put shared example dependencies to parent#48mvlcak wants to merge 2 commits into
mvlcak wants to merge 2 commits into
Conversation
…xample - make poms inherit it from parent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes why
mvn clean packagefailed with missing dependency version for one of the examples. Each example module independently declared its ownspring-ai.versionandspring-bootparent, leading to version drift across examples This caused build failures and made version updates error-prone.Changes
examples/pom.xml(examples-parent)<parent>pointing tospring-ai-agent-utils-parentsospring-ai.versionis now inherited from the root pom0.2.0-SNAPSHOTspring-boot.versionproperty (4.0.6)<dependencyManagement>importingspring-boot-dependenciesandspring-ai-bomBOMs — replacesspring-boot-starter-parentas the source of dependency versions<build><plugin>forspring-boot-maven-plugin<repositories>— inherited from rootResult
Spring AI and Spring Boot versions are now defined in one place.
Bumping a version requires changing a single property.