Commit 59957d7
committed
Pin DefaultGatewayObservationConvention behavior at unit level
Adds focused unit assertions for the gateway client observation convention
beyond the metric name renamed in the previous commit:
- guard that getName() does not equal Spring Web's http.client.requests
- getContextualName span naming
- low-cardinality key set (http.method, http.status_code, and both
spring.cloud.gateway.route.* keys)
Previously only covered indirectly by the integration-style
ObservedHttpHeadersFilterTests.
See gh-3153
Signed-off-by: Jooyoung Jung <143606756+LivingLikeKrillin@users.noreply.github.com>1 parent 4ab710c commit 59957d7
1 file changed
Lines changed: 41 additions & 0 deletions
File tree
- spring-cloud-gateway-server-webflux/src/test/java/org/springframework/cloud/gateway/filter/headers/observation
Lines changed: 41 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| 19 | + | |
| 20 | + | |
19 | 21 | | |
20 | 22 | | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
21 | 29 | | |
22 | 30 | | |
23 | 31 | | |
| |||
28 | 36 | | |
29 | 37 | | |
30 | 38 | | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
31 | 72 | | |
0 commit comments