Adds StripContextPath filter [webflux]#4129
Open
garvit-joshi wants to merge 1 commit intospring-cloud:mainfrom
Open
Adds StripContextPath filter [webflux]#4129garvit-joshi wants to merge 1 commit intospring-cloud:mainfrom
garvit-joshi wants to merge 1 commit intospring-cloud:mainfrom
Conversation
Signed-off-by: Garvit Joshi <garvitjoshi9@gmail.com>
spencergibb
reviewed
Apr 1, 2026
| newPath = "/"; | ||
| } | ||
|
|
||
| ServerHttpRequest newRequest = request.mutate().contextPath("").path(newPath).build(); |
Member
There was a problem hiding this comment.
Not a big fan of setting things to an empty string. Does null work here instead?
Contributor
Author
There was a problem hiding this comment.
I tried null, but it does not compile here. contextPath(...) is treated as non-null and NullAway fails the build with:
passing @Nullable parameter 'null' where @NonNull is required
So I kept contextPath("") for now.
Member
There was a problem hiding this comment.
Interesting, the field in the builder is nullable and in the constructor but not the builder method. @rstoyanchev is that an oversight?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #1935