Add test coverage for incomplete CORS preflight requests#4173
Open
njp2k5 wants to merge 1 commit into
Open
Conversation
Signed-off-by: njp2k5 <nikhiljp05@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a test case verifying that OPTIONS requests missing the Access-Control-Request-Method header (incomplete CORS preflight) return HTTP 403 Forbidden under the existing global CORS configuration.
Changes:
- New test method
testPreFlightCorsRequestWithoutAccessControlRequestMethodinCorsGlobalTests.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds test coverage for OPTIONS requests missing the
Access-Control-Request-Method header.
This verifies current global CORS handling for incomplete preflight requests
and helps prevent regressions in request validation behavior.
tested with ./mvnw test -pl spring-cloud-gateway-server-webflux -Dtest=CorsGlobalTests