Correct filter name from PreserveHostHeader to preserveHost#4211
Closed
think-gem wants to merge 1 commit into
Closed
Correct filter name from PreserveHostHeader to preserveHost#4211think-gem wants to merge 1 commit into
think-gem wants to merge 1 commit into
Conversation
In the WebMVC version of Spring Cloud Gateway, the global defaultFilters property (available in WebFlux) is missing. I hope the official team can add this feature. Currently, if I add filters to each route, the filter name for the route is preserveHost instead of PreserveHostHeader. Signed-off-by: thinkgem <thinkgem@163.com>
Contributor
|
Please open a separate issue about the defaultFilters. I think the right way to address this PreserveHostHeader issue is to make the name match WebFlux. I have opened a PR here for this: #4213 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the WebMVC version of Spring Cloud Gateway, the global defaultFilters property (available in WebFlux) is missing. I hope the official team can add this feature. Currently, if I add filters to each route, the filter name for the route is preserveHost instead of PreserveHostHeader.