Refactor EurekaServerInitializerConfiguration#4571
Open
alihsan-tsdln wants to merge 2 commits into
Open
Conversation
added 2 commits
May 21, 2026 11:24
Replace the raw 'new Thread' creation with CompletableFuture.runAsync() to align with modern Java concurrency practices. Consolidate field injection and ServletContextAware into a single constructor. Add the volatile keyword to the 'running' flag to ensure thread visibility across the container. Inject ApplicationEventPublisher instead of the full ApplicationContext to improve interface segregation. Fixes spring-cloudgh-4570 Signed-off-by: Ali Ihsan TASDELEN <alihsan.tsdln@gmail.com>
Replace the raw 'new Thread' creation with CompletableFuture.runAsync() to align with modern Java concurrency practices. Consolidate field injection and ServletContextAware into a single constructor. Add the volatile keyword to the 'running' flag to ensure thread visibility across the container. Inject ApplicationEventPublisher instead of the full ApplicationContext to improve interface segregation. Fixes spring-cloudgh-4570 Signed-off-by: Ali Ihsan TASDELEN <alihsan.tsdln@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the raw 'new Thread' creation with
CompletableFuture.runAsync() to align with modern
Java concurrency practices.
Consolidate field injection and ServletContextAware
into a single constructor. Add the volatile keyword
to the 'running' flag to ensure thread visibility
across the container. Inject ApplicationEventPublisher
instead of the full ApplicationContext to improve
interface segregation.
Fixes gh-4570