Skip to content

Commit 843e32a

Browse files
committed
Fix unconditional overwrite of resolved fallbackFactory bean property
eagerlyRegisterFeignClientBeanDefinition resolves the fallbackFactory attribute via ClassUtils.resolveClassName when it is provided as a String, but then unconditionally re-sets the property to the raw attribute value, discarding the resolution. Remove the duplicate addPropertyValue so the resolved value survives, matching the handling already present for fallback (a few lines above) and for the lazy registration path. Fixes gh-1367 Signed-off-by: seonwoo_jung <laborlawseon@kap.kr>
1 parent 220cb63 commit 843e32a

1 file changed

Lines changed: 0 additions & 1 deletion

File tree

spring-cloud-openfeign-core/src/main/java/org/springframework/cloud/openfeign/FeignClientsRegistrar.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -241,7 +241,6 @@ private void eagerlyRegisterFeignClientBeanDefinition(String className, Map<Stri
241241
definition.addPropertyValue("fallbackFactory", fallbackFactory instanceof Class ? fallbackFactory
242242
: ClassUtils.resolveClassName(fallbackFactory.toString(), null));
243243
}
244-
definition.addPropertyValue("fallbackFactory", attributes.get("fallbackFactory"));
245244
definition.setAutowireMode(AbstractBeanDefinition.AUTOWIRE_BY_TYPE);
246245
definition.addPropertyValue("refreshableClient", isClientRefreshEnabled());
247246
String[] qualifiers = getQualifiers(attributes);

0 commit comments

Comments
 (0)