Fix #1324: Add @JsonAlias support to SimplePageable for SNAKE_CASE compatibility

Signed-off-by: weslyvinicius <weslyvinicius@hotmail.com>

Author: weslyvinicius

spring-cloud-openfeign-core/src/main/java/org/springframework/cloud/openfeign/support/PageJacksonModule.java

@@ -243,9 +243,10 @@ static class SimplePageable implements Pageable {
 		private final PageRequest delegate;
 
 		SimplePageable(
-			@JsonProperty("pageNumber") @JsonAlias({"page-number", "page_number", "pagenumber", "PageNumber"}) int number,
-			@JsonProperty("pageSize") @JsonAlias({"page-size", "page_size", "pagesize", "PageSize"}) int size,
-			@JsonProperty("sort") Sort sort) {
+				@JsonProperty("pageNumber") @JsonAlias({ "page-number", "page_number", "pagenumber",
+						"PageNumber" }) int number,
+				@JsonProperty("pageSize") @JsonAlias({ "page-size", "page_size", "pagesize", "PageSize" }) int size,
+				@JsonProperty("sort") Sort sort) {
 			delegate = buildPageRequest(number, size, sort);
 		}
 

spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/support/PageJacksonModuleTests.java

@@ -192,11 +192,11 @@ void serializeAndDeserializeFilledMultipleCascade() throws JsonProcessingExcepti
 	@Test
 	void deserializePageableWithHyphenatedAlias() throws IOException {
 		// Given
-		ObjectMapper snakeCaseMapper = objectMapper.copy();
-		snakeCaseMapper.setPropertyNamingStrategy(PropertyNamingStrategies.KEBAB_CASE);
+		ObjectMapper kebabOjectMapepr = objectMapper.copy();
+		kebabOjectMapepr.setPropertyNamingStrategy(PropertyNamingStrategies.KEBAB_CASE);
 		File file = new File("./src/test/resources/withPageableAliasHyphen.json");
 		// When
-		Page<?> result = objectMapper.readValue(file, Page.class);
+		Page<?> result = kebabOjectMapepr.readValue(file, Page.class);
 		// Then
 		assertThat(result).isNotNull();
 		assertThat(result.getTotalElements()).isEqualTo(15);
@@ -231,13 +231,13 @@ void deserializePageableWithUnderscoreAlias() throws IOException {
 	@Test
 	void deserializePageableWithLowercaseAlias() throws IOException {
 		// Given
-		ObjectMapper snakeCaseMapper = objectMapper.copy();
-		snakeCaseMapper.setPropertyNamingStrategy(PropertyNamingStrategies.LOWER_CASE);
+		ObjectMapper lowerCaseMapper = objectMapper.copy();
+		lowerCaseMapper.setPropertyNamingStrategy(PropertyNamingStrategies.LOWER_CASE);
 
 		File file = new File("./src/test/resources/withPageableAliasLowercase.json");
 
 		// When
-		Page<?> result = objectMapper.readValue(file, Page.class);
+		Page<?> result = lowerCaseMapper.readValue(file, Page.class);
 		// Then
 		assertThat(result).isNotNull();
 		assertThat(result.getTotalElements()).isEqualTo(8);
@@ -251,12 +251,12 @@ void deserializePageableWithLowercaseAlias() throws IOException {
 	@Test
 	void deserializePageableWithPascalCaseAlias() throws IOException {
 		// Given
-		ObjectMapper snakeCaseMapper = objectMapper.copy();
-		snakeCaseMapper.setPropertyNamingStrategy(PropertyNamingStrategies.UPPER_CAMEL_CASE);
+		ObjectMapper upperCamelCaseMapper = objectMapper.copy();
+		upperCamelCaseMapper.setPropertyNamingStrategy(PropertyNamingStrategies.UPPER_CAMEL_CASE);
 		File file = new File("./src/test/resources/withPageableAliasPascalCase.json");
 
 		// When
-		Page<?> result = objectMapper.readValue(file, Page.class);
+		Page<?> result = upperCamelCaseMapper.readValue(file, Page.class);
 		// Then
 		assertThat(result).isNotNull();
 		assertThat(result.getTotalElements()).isEqualTo(20);