Add support for PageSerializationMode.VIA_DTO (PagedModel) in PageJacksonModule#1189
Add support for PageSerializationMode.VIA_DTO (PagedModel) in PageJacksonModule#1189bruce-stewart wants to merge 9 commits into
Conversation
…ksonModule Signed-off-by: bstewart <bruce.stewart@altron.com>
…art/spring-cloud-openfeign into pagedmodel-issue-1144
OlgaMaciaszek
left a comment
There was a problem hiding this comment.
Hello @bruce-stewart, thanks for submitting the PR. Looks good. Please update the date in the license comments on top of all the java classes you've changed to -2025. Also, please add the @author tag with your full name and surname to the javadocs of the classes you've modified.
We now require the contributors to adhere to the DCO by signing-off their commits. Please follow these steps to amend your commits: https://github.com/spring-cloud/spring-cloud-openfeign/pull/1189/checks?check_run_id=41357021058.
…ksonModule Signed-off-by: bstewart <bruce.stewart@altron.com>
…art/spring-cloud-openfeign into pagedmodel-issue-1144
…ksonModule Add @author javadoc Update license comments to 2025 Add support for PageSerializationMode.VIA_DTO (PagedModel) in PageJacksonModule Signed-off-by: bruce-stewart <bandi.stewart+github@gmail.com>
…dmodel-issue-1144
|
@OlgaMaciaszek Apologies for the clearly chaotic commit history on this - I have very little experience with contributing to Github projects, so my attempts at re-basing seem to be creating a lot of noise! I have updated the Copyright date and added my name as an author. I've been trying to clean up the sign-off commit comment, but am not having much success. Please let me know if there is something more that I should fix. |
|
Hi @bruce-stewart, unfortunately, the commit sign-off will be required ( |
|
Thanks @OlgaMaciaszek I'll do a new pull request |
|
I've created a new PR #1193 |
This pull request addresses issue #1144