Fix #916: Include all produces values in Accept header#1354
Merged
ryanjbaxter merged 2 commits intospring-cloud:4.3.xfrom Mar 30, 2026
Merged
Fix #916: Include all produces values in Accept header#1354ryanjbaxter merged 2 commits intospring-cloud:4.3.xfrom
ryanjbaxter merged 2 commits intospring-cloud:4.3.xfrom
Conversation
Fixes spring-cloudgh-916 Signed-off-by: Olof Segergren <olle.segergren@gmail.com>
Segergren
changed the title
ryanjbaxter
requested changes
Mar 25, 2026
...nfeign-core/src/main/java/org/springframework/cloud/openfeign/support/SpringMvcContract.java
Outdated
Show resolved
Hide resolved
...nfeign-core/src/main/java/org/springframework/cloud/openfeign/support/SpringMvcContract.java
Show resolved
Hide resolved
Signed-off-by: Segergren <olle.segergren@gmail.com>
Segergren
force-pushed
the
fix/multiple-produces-accept-header
branch
from
9e30164 to
738dd18
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SpringMvcContract.parseProduces()only used the first element ofproduces, silently dropping additional media types from theAcceptheader.Before:
Accept: application/joseAfter:
Accept: application/jose, application/jsonFixes gh-916