Document potential resource exhaustion risk when Client is not singleton#1356
Merged
ryanjbaxter merged 1 commit intospring-cloud:mainfrom Mar 30, 2026
Merged
Conversation
…eton in FeignClientFactoryBean Signed-off-by: 98001yash <yashchauhan.gaya@gmail.com>
98001yash
force-pushed
the
fix/feign-client-resource-exhaustion
branch
from
331043a to
4a773bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
FeignClientFactoryBean#getTarget() resolves the Client bean from the application context. If the Client is not configured as a singleton, repeated resolution may lead to resource exhaustion (e.g., connection pools, threads), aligning with the RCTP (Repeatedly Create Thread Pool) anti-pattern.
Solution
Added a clarifying comment indicating that the Client bean should ideally be configured as a singleton to avoid potential resource exhaustion.
Impact