From 4a773bd4424f8f50f38ac4c0354edc0eb54050aa Mon Sep 17 00:00:00 2001
From: 98001yash <yashchauhan.gaya@gmail.com>
Date: Sat, 28 Mar 2026 09:23:15 +0530
Subject: [PATCH] Add note about potential resource exhaustion when Client is
 not singleton in FeignClientFactoryBean

Signed-off-by: 98001yash <yashchauhan.gaya@gmail.com>
---
 .../cloud/openfeign/FeignClientFactoryBean.java                | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/spring-cloud-openfeign-core/src/main/java/org/springframework/cloud/openfeign/FeignClientFactoryBean.java b/spring-cloud-openfeign-core/src/main/java/org/springframework/cloud/openfeign/FeignClientFactoryBean.java
index 2e2183c53..2e2c79153 100644
--- a/spring-cloud-openfeign-core/src/main/java/org/springframework/cloud/openfeign/FeignClientFactoryBean.java
+++ b/spring-cloud-openfeign-core/src/main/java/org/springframework/cloud/openfeign/FeignClientFactoryBean.java
@@ -483,6 +483,9 @@ <T> T getTarget() {
 		if (StringUtils.hasText(url) && !url.startsWith("http://") && !url.startsWith("https://")) {
 			url = "http://" + url;
 		}
+		// NOTE: The Client bean should ideally be configured as a singleton.
+		// Repeated resolution of Client instances may lead to resource exhaustion
+		// (e.g., connection pools, threads) if not properly managed.
 		Client client = getOptional(feignClientFactory, Client.class);
 		if (client != null) {
 			if (client instanceof FeignBlockingLoadBalancerClient) {