Commit fb51ef2
authored
Fix streaming
Intermediate streaming chunks set `ChatGenerationMetadata.finishReason`
to `"_UNKNOWN"` instead of `null`. This happened because
`chunkToChatCompletion()` uses `FinishReason.of("")` as a placeholder
to satisfy the non-streaming builder, which the SDK resolves to the
internal `_UNKNOWN` value. Fix this by mapping `_UNKNOWN` to `null` in
`buildGeneration()`.
Resolves #6625
Closes #6634
Signed-off-by: Ilayaperumal Gopinathan <ilayaperumal.gopinathan@broadcom.com>finishReason in OpenAiChatModel
1 parent d1e1e6c commit fb51ef2
3 files changed
Lines changed: 38 additions & 1 deletion
File tree
- models/spring-ai-openai/src
- main/java/org/springframework/ai/openai
- test/java/org/springframework/ai/openai
- chat
Lines changed: 3 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
384 | 384 | | |
385 | 385 | | |
386 | 386 | | |
| 387 | + | |
387 | 388 | | |
388 | | - | |
| 389 | + | |
| 390 | + | |
389 | 391 | | |
390 | 392 | | |
391 | 393 | | |
| |||
Lines changed: 16 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1383 | 1383 | | |
1384 | 1384 | | |
1385 | 1385 | | |
| 1386 | + | |
| 1387 | + | |
| 1388 | + | |
| 1389 | + | |
| 1390 | + | |
| 1391 | + | |
| 1392 | + | |
| 1393 | + | |
| 1394 | + | |
| 1395 | + | |
| 1396 | + | |
| 1397 | + | |
| 1398 | + | |
| 1399 | + | |
| 1400 | + | |
| 1401 | + | |
1386 | 1402 | | |
Lines changed: 19 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
211 | 211 | | |
212 | 212 | | |
213 | 213 | | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
214 | 233 | | |
215 | 234 | | |
216 | 235 | | |
| |||
0 commit comments