Skip to content

Commit 76001f8

Browse files
committed
Temporarily disable JMS tests based on RepeatTemplate
These tests should be refactored to remove the usage of RepeatTemplate.
1 parent bcefb68 commit 76001f8

6 files changed

Lines changed: 12 additions & 4 deletions

File tree

spring-batch-infrastructure/src/test/java/org/springframework/batch/infrastructure/jms/BatchMessageListenerContainerIntegrationTests.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,7 @@
2929
import jakarta.jms.MessageListener;
3030
import jakarta.jms.TextMessage;
3131

32-
import org.junit.jupiter.api.AfterEach;
33-
import org.junit.jupiter.api.AfterAll;
34-
import org.junit.jupiter.api.BeforeEach;
35-
import org.junit.jupiter.api.Test;
32+
import org.junit.jupiter.api.*;
3633

3734
import org.springframework.beans.factory.annotation.Autowired;
3835
import org.springframework.jms.core.JmsTemplate;
@@ -49,6 +46,7 @@
4946
* @author Mahmoud Ben Hassine
5047
*
5148
*/
49+
@Disabled("Need to be refactored to remove usage of RepeatTemplate")
5250
@SpringJUnitConfig(locations = "/org/springframework/batch/infrastructure/jms/jms-context.xml")
5351
@DirtiesContext
5452
class BatchMessageListenerContainerIntegrationTests {

spring-batch-infrastructure/src/test/java/org/springframework/batch/infrastructure/repeat/jms/AsynchronousTests.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323

2424
import org.junit.jupiter.api.AfterEach;
2525
import org.junit.jupiter.api.BeforeEach;
26+
import org.junit.jupiter.api.Disabled;
2627
import org.junit.jupiter.api.Test;
2728

2829
import org.springframework.batch.infrastructure.jms.BatchMessageListenerContainer;
@@ -38,6 +39,7 @@
3839
import static org.junit.jupiter.api.Assertions.assertNull;
3940
import static org.junit.jupiter.api.Assertions.assertTrue;
4041

42+
@Disabled("Need to be refactored to remove usage of RepeatTemplate")
4143
@SpringJUnitConfig(locations = "/org/springframework/batch/infrastructure/jms/jms-context.xml")
4244
@DirtiesContext(classMode = DirtiesContext.ClassMode.BEFORE_EACH_TEST_METHOD)
4345
class AsynchronousTests {

spring-batch-infrastructure/src/test/java/org/springframework/batch/infrastructure/repeat/jms/SynchronousTests.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
import jakarta.jms.ConnectionFactory;
2727
import jakarta.jms.JMSException;
2828

29+
import org.junit.jupiter.api.Disabled;
2930
import org.junit.jupiter.api.Test;
3031

3132
import org.springframework.batch.infrastructure.repeat.RepeatStatus;
@@ -46,6 +47,7 @@
4647
import org.springframework.transaction.support.TransactionCallback;
4748
import org.springframework.transaction.support.TransactionTemplate;
4849

50+
@Disabled("Need to be refactored to remove usage of RepeatTemplate")
4951
@SpringJUnitConfig(locations = "/org/springframework/batch/infrastructure/jms/jms-context.xml")
5052
@DirtiesContext
5153
class SynchronousTests implements ApplicationContextAware {

spring-batch-infrastructure/src/test/java/org/springframework/batch/infrastructure/retry/jms/ExternalRetryInBatchTests.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818

1919
import org.junit.jupiter.api.AfterEach;
2020
import org.junit.jupiter.api.BeforeEach;
21+
import org.junit.jupiter.api.Disabled;
2122
import org.junit.jupiter.api.Test;
2223
import org.springframework.batch.infrastructure.item.ItemReader;
2324
import org.springframework.batch.infrastructure.repeat.RepeatStatus;
@@ -44,6 +45,7 @@
4445

4546
import static org.junit.jupiter.api.Assertions.assertEquals;
4647

48+
@Disabled("Need to be refactored to remove usage of RepeatTemplate")
4749
@SpringJUnitConfig(locations = "/org/springframework/batch/infrastructure/jms/jms-context.xml")
4850
class ExternalRetryInBatchTests {
4951

spring-batch-infrastructure/src/test/java/org/springframework/batch/infrastructure/retry/jms/ExternalRetryTests.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
import java.util.List;
2121

2222
import org.junit.jupiter.api.BeforeEach;
23+
import org.junit.jupiter.api.Disabled;
2324
import org.junit.jupiter.api.Test;
2425

2526
import org.springframework.batch.infrastructure.item.Chunk;
@@ -40,6 +41,7 @@
4041
import static org.junit.jupiter.api.Assertions.assertEquals;
4142
import static org.junit.jupiter.api.Assertions.assertThrows;
4243

44+
@Disabled("Need to be refactored to remove usage of RepeatTemplate")
4345
@SpringJUnitConfig(locations = "/org/springframework/batch/infrastructure/jms/jms-context.xml")
4446
class ExternalRetryTests {
4547

spring-batch-infrastructure/src/test/java/org/springframework/batch/infrastructure/retry/jms/SynchronousTests.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
package org.springframework.batch.infrastructure.retry.jms;
1818

1919
import org.junit.jupiter.api.BeforeEach;
20+
import org.junit.jupiter.api.Disabled;
2021
import org.junit.jupiter.api.Test;
2122
import org.springframework.batch.infrastructure.item.jms.JmsItemReader;
2223
import org.springframework.beans.factory.annotation.Autowired;
@@ -41,6 +42,7 @@
4142
import static org.junit.jupiter.api.Assertions.assertThrows;
4243
import static org.junit.jupiter.api.Assertions.assertTrue;
4344

45+
@Disabled("Need to be refactored to remove usage of RepeatTemplate")
4446
@SpringJUnitConfig(locations = "/org/springframework/batch/infrastructure/jms/jms-context.xml")
4547
public class SynchronousTests {
4648

0 commit comments

Comments
 (0)