Skip to content

Commit 155b02f

Browse files
nosansnicoll
authored andcommitted
Use new Maven Resolver API for ModifiedClassPathClassLoader
Replace deprecated Maven Resolver components with `RepositorySystemSupplier`. See gh-50447 Signed-off-by: Dmytro Nosan <dimanosan@gmail.com>
1 parent 351a826 commit 155b02f

3 files changed

Lines changed: 35 additions & 41 deletions

File tree

spring-boot-project/spring-boot-parent/build.gradle

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,13 +150,14 @@ bom {
150150
]
151151
}
152152
}
153-
library("Maven Resolver", "1.9.23") {
153+
library("Maven Resolver", "1.9.27") {
154154
group("org.apache.maven.resolver") {
155155
modules = [
156156
"maven-resolver-api",
157157
"maven-resolver-connector-basic",
158158
"maven-resolver-impl",
159159
"maven-resolver-spi",
160+
"maven-resolver-supplier",
160161
"maven-resolver-transport-file",
161162
"maven-resolver-transport-http",
162163
"maven-resolver-util"

spring-boot-project/spring-boot-tools/spring-boot-test-support/build.gradle

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -37,12 +37,7 @@ dependencies {
3737
compileOnly("org.springframework.data:spring-data-redis")
3838

3939
implementation("jakarta.inject:jakarta.inject-api")
40-
implementation("org.apache.maven.resolver:maven-resolver-connector-basic")
41-
implementation("org.apache.maven.resolver:maven-resolver-impl")
42-
implementation("org.apache.maven:maven-resolver-provider") {
43-
exclude(group: "javax.inject", module: "javax.inject")
44-
}
45-
implementation("org.apache.maven.resolver:maven-resolver-transport-http") {
40+
implementation("org.apache.maven.resolver:maven-resolver-supplier") {
4641
exclude group: "org.slf4j", module: "jcl-over-slf4j"
4742
}
4843
implementation("org.assertj:assertj-core")

spring-boot-project/spring-boot-tools/spring-boot-test-support/src/main/java/org/springframework/boot/testsupport/classpath/ModifiedClassPathClassLoader.java

Lines changed: 32 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -42,16 +42,13 @@
4242
import org.eclipse.aether.RepositorySystem;
4343
import org.eclipse.aether.artifact.DefaultArtifact;
4444
import org.eclipse.aether.collection.CollectRequest;
45-
import org.eclipse.aether.connector.basic.BasicRepositoryConnectorFactory;
4645
import org.eclipse.aether.graph.Dependency;
4746
import org.eclipse.aether.repository.LocalRepository;
4847
import org.eclipse.aether.repository.RemoteRepository;
4948
import org.eclipse.aether.resolution.ArtifactResult;
5049
import org.eclipse.aether.resolution.DependencyRequest;
5150
import org.eclipse.aether.resolution.DependencyResult;
52-
import org.eclipse.aether.spi.connector.RepositoryConnectorFactory;
53-
import org.eclipse.aether.spi.connector.transport.TransporterFactory;
54-
import org.eclipse.aether.transport.http.HttpTransporterFactory;
51+
import org.eclipse.aether.supplier.RepositorySystemSupplier;
5552

5653
import org.springframework.core.annotation.MergedAnnotation;
5754
import org.springframework.core.annotation.MergedAnnotations;
@@ -242,41 +239,42 @@ private static List<URL> getAdditionalUrls(List<MergedAnnotations> annotations)
242239

243240
private static List<URL> resolveCoordinates(String[] coordinates) {
244241
Exception latestFailure = null;
245-
RepositorySystem repositorySystem = createRepositorySystem();
246-
DefaultRepositorySystemSession session = MavenRepositorySystemUtils.newSession();
247-
session.setSystemProperties(System.getProperties());
248-
LocalRepository localRepository = new LocalRepository(System.getProperty("user.home") + "/.m2/repository");
249-
RemoteRepository remoteRepository = new RemoteRepository.Builder("central", "default",
250-
"https://repo.maven.apache.org/maven2")
251-
.build();
252-
session.setLocalRepositoryManager(repositorySystem.newLocalRepositoryManager(session, localRepository));
253-
for (int i = 0; i < MAX_RESOLUTION_ATTEMPTS; i++) {
254-
CollectRequest collectRequest = new CollectRequest(null, Arrays.asList(remoteRepository));
255-
collectRequest.setDependencies(createDependencies(coordinates));
256-
DependencyRequest dependencyRequest = new DependencyRequest(collectRequest, null);
257-
try {
258-
DependencyResult result = repositorySystem.resolveDependencies(session, dependencyRequest);
259-
List<URL> resolvedArtifacts = new ArrayList<>();
260-
for (ArtifactResult artifact : result.getArtifactResults()) {
261-
resolvedArtifacts.add(artifact.getArtifact().getFile().toURI().toURL());
242+
RepositorySystem repositorySystem = new RepositorySystemSupplier().get();
243+
try {
244+
DefaultRepositorySystemSession session = MavenRepositorySystemUtils.newSession();
245+
session.setSystemProperties(System.getProperties());
246+
LocalRepository localRepository = new LocalRepository(System.getProperty("user.home") + "/.m2/repository");
247+
RemoteRepository remoteRepository = new RemoteRepository.Builder("central", "default",
248+
"https://repo.maven.apache.org/maven2")
249+
.build();
250+
session.setLocalRepositoryManager(repositorySystem.newLocalRepositoryManager(session, localRepository));
251+
for (int i = 0; i < MAX_RESOLUTION_ATTEMPTS; i++) {
252+
CollectRequest collectRequest = new CollectRequest(null, Arrays.asList(remoteRepository));
253+
collectRequest.setDependencies(createDependencies(coordinates));
254+
DependencyRequest dependencyRequest = new DependencyRequest(collectRequest, null);
255+
try {
256+
DependencyResult result = repositorySystem.resolveDependencies(session, dependencyRequest);
257+
List<URL> resolvedArtifacts = new ArrayList<>();
258+
for (ArtifactResult artifact : result.getArtifactResults()) {
259+
resolvedArtifacts.add(artifact.getArtifact().getFile().toURI().toURL());
260+
}
261+
return resolvedArtifacts;
262+
}
263+
catch (Exception ex) {
264+
latestFailure = ex;
262265
}
263-
return resolvedArtifacts;
266+
}
267+
throw new IllegalStateException("Resolution failed after " + MAX_RESOLUTION_ATTEMPTS + " attempts",
268+
latestFailure);
269+
}
270+
finally {
271+
try {
272+
repositorySystem.shutdown();
264273
}
265274
catch (Exception ex) {
266-
latestFailure = ex;
275+
// Ignore
267276
}
268277
}
269-
throw new IllegalStateException("Resolution failed after " + MAX_RESOLUTION_ATTEMPTS + " attempts",
270-
latestFailure);
271-
}
272-
273-
@SuppressWarnings("deprecation")
274-
private static RepositorySystem createRepositorySystem() {
275-
org.eclipse.aether.impl.DefaultServiceLocator serviceLocator = MavenRepositorySystemUtils.newServiceLocator();
276-
serviceLocator.addService(RepositoryConnectorFactory.class, BasicRepositoryConnectorFactory.class);
277-
serviceLocator.addService(TransporterFactory.class, HttpTransporterFactory.class);
278-
RepositorySystem repositorySystem = serviceLocator.getService(RepositorySystem.class);
279-
return repositorySystem;
280278
}
281279

282280
private static List<Dependency> createDependencies(String[] allCoordinates) {

0 commit comments

Comments
 (0)