Skip to content

Commit 3638852

Browse files
committed
Merge branch '4.0.x'
Closes gh-50612
2 parents f281ff4 + 170c52f commit 3638852

2 files changed

Lines changed: 14 additions & 2 deletions

File tree

module/spring-boot-amqp/src/main/java/org/springframework/boot/amqp/autoconfigure/RabbitProperties.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -479,7 +479,7 @@ public class Ssl {
479479
* @see #getEnabled() ()
480480
*/
481481
public boolean determineEnabled() {
482-
boolean defaultEnabled = Boolean.TRUE.equals(getEnabled()) || this.bundle != null;
482+
boolean defaultEnabled = Boolean.TRUE.equals(getEnabled()) || StringUtils.hasText(this.bundle);
483483
if (CollectionUtils.isEmpty(RabbitProperties.this.parsedAddresses)) {
484484
return defaultEnabled;
485485
}
@@ -1387,7 +1387,7 @@ public static class Ssl {
13871387
}
13881388

13891389
public boolean determineEnabled() {
1390-
return Boolean.TRUE.equals(getEnabled()) || this.bundle != null;
1390+
return Boolean.TRUE.equals(getEnabled()) || StringUtils.hasText(this.bundle);
13911391
}
13921392

13931393
public void setEnabled(@Nullable Boolean enabled) {

module/spring-boot-amqp/src/test/java/org/springframework/boot/amqp/autoconfigure/RabbitPropertiesTests.java

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -336,6 +336,12 @@ void determineSslEnabledIsTrueWhenBundleIsSetAndNoAddresses() {
336336
assertThat(this.properties.getSsl().determineEnabled()).isTrue();
337337
}
338338

339+
@Test
340+
void determineSslEnabledIsFalseWhenBundleIsEmpty() {
341+
this.properties.getSsl().setBundle("");
342+
assertThat(this.properties.getSsl().determineEnabled()).isFalse();
343+
}
344+
339345
@Test
340346
void propertiesUseConsistentDefaultValues() {
341347
ConnectionFactory connectionFactory = new ConnectionFactory();
@@ -399,6 +405,12 @@ void streamSslIsEnabledWhenBundleIsSet() {
399405
assertThat(this.properties.getStream().getSsl().determineEnabled()).isTrue();
400406
}
401407

408+
@Test
409+
void streamSslIsDisabledWhenBundleIsEmpty() {
410+
this.properties.getStream().getSsl().setBundle("");
411+
assertThat(this.properties.getStream().getSsl().determineEnabled()).isFalse();
412+
}
413+
402414
@Test
403415
void streamSslIsDisabledWhenEnabledIsFalseAndBundleIsNotSet() {
404416
this.properties.getStream().getSsl().setEnabled(false);

0 commit comments

Comments
 (0)