Merge pull request #50750 from quaff

wilkinsona · wilkinsona · commit 790f66c37a6f · 2026-06-24T19:12:20.000+01:00
Closes gh-50750 * gh-50750: Replace `isAssignableFrom()` with `isInstance()` where feasible
diff --git a/build-plugin/spring-boot-maven-plugin/src/main/java/org/springframework/boot/maven/StartMojo.java b/build-plugin/spring-boot-maven-plugin/src/main/java/org/springframework/boot/maven/StartMojo.java
@@ -233,7 +233,7 @@ private class CreateJmxConnector implements Callable<@Nullable JMXConnector> {
 		}
 
 		private boolean hasCauseWithType(Throwable t, Class<? extends Exception> type) {
-			return type.isAssignableFrom(t.getClass()) || t.getCause() != null && hasCauseWithType(t.getCause(), type);
+			return type.isInstance(t) || t.getCause() != null && hasCauseWithType(t.getCause(), type);
 		}
 
 	}
diff --git a/config/checkstyle/checkstyle.xml b/config/checkstyle/checkstyle.xml
@@ -88,6 +88,18 @@
 				value="Please use static AssertJ imports." />
 			<property name="ignoreComments" value="true" />
 		</module>
+		<module name="com.puppycrawl.tools.checkstyle.checks.regexp.RegexpSinglelineJavaCheck">
+			<property name="maximum" value="0"/>
+			<property name="format" value="\.isAssignableFrom\(.+\.getClass\(\)\)" />
+			<property name="message" value="Please use type.isInstance(object) instead." />
+			<property name="ignoreComments" value="true" />
+		</module>
+		<module name="com.puppycrawl.tools.checkstyle.checks.regexp.RegexpSinglelineJavaCheck">
+			<property name="maximum" value="0"/>
+			<property name="format" value="\w+\.class\.isInstance\(.+\)" />
+			<property name="message" value="Please use object instanceof type instead." />
+			<property name="ignoreComments" value="true" />
+		</module>
 		<module name="io.spring.javaformat.checkstyle.check.SpringJavadocCheck">
 			<property name="publicOnlySinceTags" value="true" />
 			<property name="requireSinceTag" value="true" />
diff --git a/configuration-metadata/spring-boot-configuration-processor/src/main/java/org/springframework/boot/configurationprocessor/fieldvalues/javac/ExpressionTree.java b/configuration-metadata/spring-boot-configuration-processor/src/main/java/org/springframework/boot/configurationprocessor/fieldvalues/javac/ExpressionTree.java
@@ -55,14 +55,14 @@ String getKind() throws Exception {
 	}
 
 	Object getLiteralValue() throws Exception {
-		if (this.literalTreeType.isAssignableFrom(getInstance().getClass())) {
+		if (this.literalTreeType.isInstance(getInstance())) {
 			return this.literalValueMethod.invoke(getInstance());
 		}
 		return null;
 	}
 
 	Object getFactoryValue() throws Exception {
-		if (this.methodInvocationTreeType.isAssignableFrom(getInstance().getClass())) {
+		if (this.methodInvocationTreeType.isInstance(getInstance())) {
 			List<?> arguments = (List<?>) this.methodInvocationArgumentsMethod.invoke(getInstance());
 			if (arguments.size() == 1) {
 				return new ExpressionTree(arguments.get(0)).getLiteralValue();
@@ -72,7 +72,7 @@ Object getFactoryValue() throws Exception {
 	}
 
 	Member getSelectedMember() throws Exception {
-		if (this.memberSelectTreeType.isAssignableFrom(getInstance().getClass())) {
+		if (this.memberSelectTreeType.isInstance(getInstance())) {
 			String expression = this.memberSelectTreeExpressionMethod.invoke(getInstance()).toString();
 			String identifier = this.memberSelectTreeIdentifierMethod.invoke(getInstance()).toString();
 			if (expression != null && identifier != null) {
@@ -83,7 +83,7 @@ Member getSelectedMember() throws Exception {
 	}
 
 	List<? extends ExpressionTree> getArrayExpression() throws Exception {
-		if (this.newArrayTreeType.isAssignableFrom(getInstance().getClass())) {
+		if (this.newArrayTreeType.isInstance(getInstance())) {
 			List<?> elements = (List<?>) this.arrayValueMethod.invoke(getInstance());
 			List<ExpressionTree> result = new ArrayList<>();
 			if (elements == null) {
diff --git a/core/spring-boot/src/main/java/org/springframework/boot/diagnostics/analyzer/AbstractInjectionFailureAnalyzer.java b/core/spring-boot/src/main/java/org/springframework/boot/diagnostics/analyzer/AbstractInjectionFailureAnalyzer.java
@@ -64,7 +64,7 @@ public abstract class AbstractInjectionFailureAnalyzer<T extends Throwable> exte
 		Throwable candidate = root;
 		C result = null;
 		while (candidate != null) {
-			if (type.isAssignableFrom(candidate.getClass())) {
+			if (type.isInstance(candidate)) {
 				result = (C) candidate;
 			}
 			candidate = candidate.getCause();
diff --git a/core/spring-boot/src/main/java/org/springframework/boot/json/AbstractJsonParser.java b/core/spring-boot/src/main/java/org/springframework/boot/json/AbstractJsonParser.java
@@ -55,7 +55,7 @@ protected final <T> T tryParse(Callable<T> parser, Class<? extends Exception> ch
 			return parser.call();
 		}
 		catch (Exception ex) {
-			if (check.isAssignableFrom(ex.getClass())) {
+			if (check.isInstance(ex)) {
 				throw new JsonParseException(ex);
 			}
 			ReflectionUtils.rethrowRuntimeException(ex);
diff --git a/module/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/context/properties/ConfigurationPropertiesReportEndpoint.java b/module/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/context/properties/ConfigurationPropertiesReportEndpoint.java
@@ -337,7 +337,7 @@ else if (item instanceof List) {
 		if (value == null || ClassUtils.isPrimitiveOrWrapper(value.getClass()) || value instanceof String) {
 			return value;
 		}
-		if (CharSequence.class.isAssignableFrom(value.getClass())) {
+		if (value instanceof CharSequence) {
 			return value.toString();
 		}
 		return "Complex property value " + value.getClass().getName();
diff --git a/module/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/env/EnvironmentEndpoint.java b/module/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/env/EnvironmentEndpoint.java
@@ -208,11 +208,10 @@ private void extract(String root, Map<String, PropertySource<?>> map, PropertySo
 	}
 
 	protected @Nullable Object stringifyIfNecessary(@Nullable Object value) {
-		if (value == null || ClassUtils.isPrimitiveOrWrapper(value.getClass())
-				|| Number.class.isAssignableFrom(value.getClass())) {
+		if (value == null || ClassUtils.isPrimitiveOrWrapper(value.getClass()) || value instanceof Number) {
 			return value;
 		}
-		if (CharSequence.class.isAssignableFrom(value.getClass())) {
+		if (value instanceof CharSequence) {
 			return value.toString();
 		}
 		return "Complex property type " + value.getClass().getName();
diff --git a/module/spring-boot-http-codec/src/test/java/org/springframework/boot/http/codec/autoconfigure/CodecsAutoConfigurationTests.java b/module/spring-boot-http-codec/src/test/java/org/springframework/boot/http/codec/autoconfigure/CodecsAutoConfigurationTests.java
@@ -169,7 +169,7 @@ private <T> T findEncoder(AssertableApplicationContext context, Class<T> encoder
 			.filter((writer) -> writer instanceof EncoderHttpMessageWriter<?>)
 			.map((writer) -> (EncoderHttpMessageWriter<?>) writer)
 			.map(EncoderHttpMessageWriter::getEncoder)
-			.filter((encoder) -> encoderClass.isAssignableFrom(encoder.getClass()))
+			.filter(encoderClass::isInstance)
 			.findFirst()
 			.orElseThrow();
 	}
diff --git a/module/spring-boot-http-converter/src/test/java/org/springframework/boot/http/converter/autoconfigure/HttpMessageConvertersAutoConfigurationTests.java b/module/spring-boot-http-converter/src/test/java/org/springframework/boot/http/converter/autoconfigure/HttpMessageConvertersAutoConfigurationTests.java
@@ -465,18 +465,14 @@ private ApplicationContextRunner allOptionsRunner() {
 
 	private void assertConverterIsRegistered(AssertableApplicationContext context,
 			Class<? extends HttpMessageConverter<?>> converterType) {
-		assertThat(getClientConverters(context)).filteredOn((c) -> converterType.isAssignableFrom(c.getClass()))
-			.hasSize(1);
-		assertThat(getServerConverters(context)).filteredOn((c) -> converterType.isAssignableFrom(c.getClass()))
-			.hasSize(1);
+		assertThat(getClientConverters(context)).filteredOn(converterType::isInstance).hasSize(1);
+		assertThat(getServerConverters(context)).filteredOn(converterType::isInstance).hasSize(1);
 	}
 
 	private void assertConverterIsNotRegistered(AssertableApplicationContext context,
 			Class<? extends HttpMessageConverter<?>> converterType) {
-		assertThat(getClientConverters(context)).filteredOn((c) -> converterType.isAssignableFrom(c.getClass()))
-			.isEmpty();
-		assertThat(getServerConverters(context)).filteredOn((c) -> converterType.isAssignableFrom(c.getClass()))
-			.isEmpty();
+		assertThat(getClientConverters(context)).filteredOn(converterType::isInstance).isEmpty();
+		assertThat(getServerConverters(context)).filteredOn(converterType::isInstance).isEmpty();
 	}
 
 	private void assertBeanExists(AssertableApplicationContext context, Class<?> type, String beanName) {
@@ -504,7 +500,7 @@ private HttpMessageConverters getServerConverters(ApplicationContext context) {
 	private <T extends HttpMessageConverter<?>> T findConverter(HttpMessageConverters converters,
 			Class<? extends HttpMessageConverter<?>> type) {
 		for (HttpMessageConverter<?> converter : converters) {
-			if (type.isAssignableFrom(converter.getClass())) {
+			if (type.isInstance(converter)) {
 				return (T) converter;
 			}
 		}
@@ -589,8 +585,7 @@ static class JacksonConverterConfig {
 
 		@Bean
 		JacksonJsonHttpMessageConverter customJacksonMessageConverter(JsonMapper jsonMapperMapper) {
-			JacksonJsonHttpMessageConverter converter = new JacksonJsonHttpMessageConverter(jsonMapperMapper);
-			return converter;
+			return new JacksonJsonHttpMessageConverter(jsonMapperMapper);
 		}
 
 	}
diff --git a/module/spring-boot-jdbc/src/main/java/org/springframework/boot/jdbc/autoconfigure/JdbcConnectionDetailsBeanPostProcessor.java b/module/spring-boot-jdbc/src/main/java/org/springframework/boot/jdbc/autoconfigure/JdbcConnectionDetailsBeanPostProcessor.java
@@ -49,7 +49,7 @@ abstract class JdbcConnectionDetailsBeanPostProcessor<T> implements BeanPostProc
 	@Override
 	@SuppressWarnings("unchecked")
 	public Object postProcessBeforeInitialization(Object bean, String beanName) throws BeansException {
-		if (this.dataSourceClass.isAssignableFrom(bean.getClass()) && "dataSource".equals(beanName)) {
+		if (this.dataSourceClass.isInstance(bean) && "dataSource".equals(beanName)) {
 			JdbcConnectionDetails connectionDetails = this.connectionDetailsProvider.getObject();
 			if (!(connectionDetails instanceof PropertiesJdbcConnectionDetails)) {
 				return processDataSource((T) bean, connectionDetails);
diff --git a/module/spring-boot-micrometer-tracing/src/main/java/org/springframework/boot/micrometer/tracing/autoconfigure/TracingAndMeterObservationHandlerGroup.java b/module/spring-boot-micrometer-tracing/src/main/java/org/springframework/boot/micrometer/tracing/autoconfigure/TracingAndMeterObservationHandlerGroup.java
@@ -47,7 +47,7 @@ class TracingAndMeterObservationHandlerGroup implements ObservationHandlerGroup
 
 	@Override
 	public boolean isMember(ObservationHandler<?> handler) {
-		return MeterObservationHandler.class.isInstance(handler) || TracingObservationHandler.class.isInstance(handler);
+		return handler instanceof MeterObservationHandler || handler instanceof TracingObservationHandler;
 	}
 
 	@Override
diff --git a/module/spring-boot-tomcat/src/main/java/org/springframework/boot/tomcat/autoconfigure/TomcatWebServerFactoryCustomizer.java b/module/spring-boot-tomcat/src/main/java/org/springframework/boot/tomcat/autoconfigure/TomcatWebServerFactoryCustomizer.java
@@ -320,7 +320,7 @@ private <T extends ProtocolHandler> void customizeHandler(ConfigurableTomcatWebS
 			Class<T> type, ObjIntConsumer<T> consumer) {
 		factory.addConnectorCustomizers((connector) -> {
 			ProtocolHandler handler = connector.getProtocolHandler();
-			if (type.isAssignableFrom(handler.getClass())) {
+			if (type.isInstance(handler)) {
 				consumer.accept(type.cast(handler), value);
 			}
 		});

Original file line number	Diff line number	Diff line change
`@@ -233,7 +233,7 @@ private class CreateJmxConnector implements Callable<@Nullable JMXConnector> {`
`233`	`233`	`}`
`234`	`234`
`235`	`235`	`private boolean hasCauseWithType(Throwable t, Class<? extends Exception> type) {`
`236`		`- return type.isAssignableFrom(t.getClass()) \|\| t.getCause() != null && hasCauseWithType(t.getCause(), type);`
	`236`	`+ return type.isInstance(t) \|\| t.getCause() != null && hasCauseWithType(t.getCause(), type);`
`237`	`237`	`}`
`238`	`238`
`239`	`239`	`}`
Original file line number	Diff line number	Diff line change
`@@ -55,14 +55,14 @@ String getKind() throws Exception {`
`55`	`55`	`}`
`56`	`56`
`57`	`57`	`Object getLiteralValue() throws Exception {`
`58`		`- if (this.literalTreeType.isAssignableFrom(getInstance().getClass())) {`
	`58`	`+ if (this.literalTreeType.isInstance(getInstance())) {`
`59`	`59`	`return this.literalValueMethod.invoke(getInstance());`
`60`	`60`	`}`
`61`	`61`	`return null;`
`62`	`62`	`}`
`63`	`63`
`64`	`64`	`Object getFactoryValue() throws Exception {`
`65`		`- if (this.methodInvocationTreeType.isAssignableFrom(getInstance().getClass())) {`
	`65`	`+ if (this.methodInvocationTreeType.isInstance(getInstance())) {`
`66`	`66`	`List<?> arguments = (List<?>) this.methodInvocationArgumentsMethod.invoke(getInstance());`
`67`	`67`	`if (arguments.size() == 1) {`
`68`	`68`	`return new ExpressionTree(arguments.get(0)).getLiteralValue();`
`@@ -72,7 +72,7 @@ Object getFactoryValue() throws Exception {`
`72`	`72`	`}`
`73`	`73`
`74`	`74`	`Member getSelectedMember() throws Exception {`
`75`		`- if (this.memberSelectTreeType.isAssignableFrom(getInstance().getClass())) {`
	`75`	`+ if (this.memberSelectTreeType.isInstance(getInstance())) {`
`76`	`76`	`String expression = this.memberSelectTreeExpressionMethod.invoke(getInstance()).toString();`
`77`	`77`	`String identifier = this.memberSelectTreeIdentifierMethod.invoke(getInstance()).toString();`
`78`	`78`	`if (expression != null && identifier != null) {`
`@@ -83,7 +83,7 @@ Member getSelectedMember() throws Exception {`
`83`	`83`	`}`
`84`	`84`
`85`	`85`	`List<? extends ExpressionTree> getArrayExpression() throws Exception {`
`86`		`- if (this.newArrayTreeType.isAssignableFrom(getInstance().getClass())) {`
	`86`	`+ if (this.newArrayTreeType.isInstance(getInstance())) {`
`87`	`87`	`List<?> elements = (List<?>) this.arrayValueMethod.invoke(getInstance());`
`88`	`88`	`List<ExpressionTree> result = new ArrayList<>();`
`89`	`89`	`if (elements == null) {`
Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ public abstract class AbstractInjectionFailureAnalyzer<T extends Throwable> exte`
`64`	`64`	`Throwable candidate = root;`
`65`	`65`	`C result = null;`
`66`	`66`	`while (candidate != null) {`
`67`		`- if (type.isAssignableFrom(candidate.getClass())) {`
	`67`	`+ if (type.isInstance(candidate)) {`
`68`	`68`	`result = (C) candidate;`
`69`	`69`	`}`
`70`	`70`	`candidate = candidate.getCause();`
Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,7 @@ protected final <T> T tryParse(Callable<T> parser, Class<? extends Exception> ch`
`55`	`55`	`return parser.call();`
`56`	`56`	`}`
`57`	`57`	`catch (Exception ex) {`
`58`		`- if (check.isAssignableFrom(ex.getClass())) {`
	`58`	`+ if (check.isInstance(ex)) {`
`59`	`59`	`throw new JsonParseException(ex);`
`60`	`60`	`}`
`61`	`61`	`ReflectionUtils.rethrowRuntimeException(ex);`
Original file line number	Diff line number	Diff line change
`@@ -337,7 +337,7 @@ else if (item instanceof List) {`
`337`	`337`	`if (value == null \|\| ClassUtils.isPrimitiveOrWrapper(value.getClass()) \|\| value instanceof String) {`
`338`	`338`	`return value;`
`339`	`339`	`}`
`340`		`- if (CharSequence.class.isAssignableFrom(value.getClass())) {`
	`340`	`+ if (value instanceof CharSequence) {`
`341`	`341`	`return value.toString();`
`342`	`342`	`}`
`343`	`343`	`return "Complex property value " + value.getClass().getName();`
Original file line number	Diff line number	Diff line change
`@@ -208,11 +208,10 @@ private void extract(String root, Map<String, PropertySource<?>> map, PropertySo`
`208`	`208`	`}`
`209`	`209`
`210`	`210`	`protected @Nullable Object stringifyIfNecessary(@Nullable Object value) {`
`211`		`- if (value == null \|\| ClassUtils.isPrimitiveOrWrapper(value.getClass())`
`212`		`- \|\| Number.class.isAssignableFrom(value.getClass())) {`
	`211`	`+ if (value == null \|\| ClassUtils.isPrimitiveOrWrapper(value.getClass()) \|\| value instanceof Number) {`
`213`	`212`	`return value;`
`214`	`213`	`}`
`215`		`- if (CharSequence.class.isAssignableFrom(value.getClass())) {`
	`214`	`+ if (value instanceof CharSequence) {`
`216`	`215`	`return value.toString();`
`217`	`216`	`}`
`218`	`217`	`return "Complex property type " + value.getClass().getName();`
Original file line number	Diff line number	Diff line change
`@@ -169,7 +169,7 @@ private <T> T findEncoder(AssertableApplicationContext context, Class<T> encoder`
`169`	`169`	`.filter((writer) -> writer instanceof EncoderHttpMessageWriter<?>)`
`170`	`170`	`.map((writer) -> (EncoderHttpMessageWriter<?>) writer)`
`171`	`171`	`.map(EncoderHttpMessageWriter::getEncoder)`
`172`		`- .filter((encoder) -> encoderClass.isAssignableFrom(encoder.getClass()))`
	`172`	`+ .filter(encoderClass::isInstance)`
`173`	`173`	`.findFirst()`
`174`	`174`	`.orElseThrow();`
`175`	`175`	`}`