Skip to content

Skip registering all OTLP tracing related beans if tracing is disabled#46166

Closed
quaff wants to merge 1 commit into
spring-projects:mainfrom
quaff:patch-171
Closed

Skip registering all OTLP tracing related beans if tracing is disabled#46166
quaff wants to merge 1 commit into
spring-projects:mainfrom
quaff:patch-171

Conversation

@quaff

@quaff quaff commented Jun 23, 2025

Copy link
Copy Markdown
Contributor

Before this commit, OtlpTracingProperties and OtlpTracingConnectionDetails are registered even if tracing is disabled.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 23, 2025
@quaff quaff marked this pull request as draft June 23, 2025 08:40
@quaff

quaff commented Jun 23, 2025

Copy link
Copy Markdown
Contributor Author

It applies to other tracing AutoConfigurations such as ZipkinAutoConfiguration, should I create separate PR or append commits in this PR?

@quaff quaff marked this pull request as ready for review June 26, 2025 09:15
Before this commit, `OtlpTracingProperties` and `OtlpTracingConnectionDetails` are registered even if tracing is disabled.

Signed-off-by: Yanming Zhou <zhouyanming@gmail.com>
@mhalbritter

mhalbritter commented Aug 29, 2025

Copy link
Copy Markdown
Contributor

It's intended that OtlpTracingProperties and OtlpTracingConnectionDetails are registered. The @ConditionalOnEnabledTracing is intended to shut off tracing export (it should really be named @ConditionalOnEnabledTracingExport or something like that), not all tracing related beans.

@mhalbritter mhalbritter added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged labels Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: declined A suggestion or change that we don't feel we should currently apply

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants