Move "*.enabled" keys from metadata to dedicated @ConfigurationProperties bean#46220
Move "*.enabled" keys from metadata to dedicated @ConfigurationProperties bean#46220quaff wants to merge 1 commit into
@ConfigurationProperties bean#46220Conversation
…rties` bean Signed-off-by: Yanming Zhou <zhouyanming@gmail.com>
What makes you think that? |
|
I don't think we really have a single way to deal with enabled properties, and I'm not really sure that we should. I think there's at least one or two that only in the metadata because we don't have a All things considered, I think we should leave things as they are for now. Thanks anyway for the PR. |
See #43886 (comment) @wilkinsona prefer creating new |
|
That was a preference in a specific situation rather than a rule. Thanks again for the PR but, generally speaking, I think it's better to leave the introduction of stylistic changes that cut across the whole codebase to the core team. |
IIRC, this is the recommended way.