Layer written outside the output location of '//' exception is thrown when using extract layers in root directory#50501
Merged
mhalbritter merged 2 commits intoMay 27, 2026
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
DragonFSKY
force-pushed
the
gh-50495-root-output-directory
branch
from
3e834a2 to
2da6326
Compare
philwebb
added
type: regression
philwebb
changed the title
philwebb
changed the title
Use canonical Path containment checks so layer directories under the filesystem root are accepted while entries and layer names that escape the output directory remain rejected. See spring-projectsgh-50501 Signed-off-by: Dongliang Xie <dragonfsky@gmail.com>
mhalbritter
force-pushed
the
gh-50495-root-output-directory
branch
from
2da6326 to
db1ebf5
Compare
Contributor
|
Thanks @DragonFSKY ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running the
extract --layers --launchertools command with the filesystem root as the output directory can fail after layer directory normalization. The containment check appendsFile.separatorto the canonical output path before testing a layer location, which turns/into//and causes valid layer directories such as/dependenciesto be rejected as outside the output location.This update uses canonical
Pathcontainment checks for both entries and layer directories. It keeps the existing behavior of rejecting paths that are equal to, or outside of, the output directory, and adds command-level coverage for extraction with the filesystem root as the destination while keeping the test output under the test temporary directory.Closes #50495
Tests:
./gradlew :loader:spring-boot-jarmode-tools:check --rerun-tasks