Close URLClassLoader in ArchitectureCheck

[SebTardif]

URLClassLoader implements Closeable but was never closed in
withCompileClasspath(), leaking JAR file handles in long-running
Gradle daemon processes.

The fix declares the classloader before the try block and closes it
in the finally block after restoring the original context classloader.

[nosan]

I think you can use try-with-resources to make it a little bit better.

try (URLClassLoader classLoader = new URLClassLoader(...)) {
	Thread.currentThread().setContextClassLoader(classLoader);
	callable.call();
}
finally {
	Thread.currentThread().setContextClassLoader(previous);
}

[nosan]

I think your target branch should be 3.5.x, not main, since all branches are affected.

[SebTardif]

Thanks @nosan for the review!

• Retargeted base to 3.5.x as suggested (the leak affects the build on all lines).
• Switched to try-with-resources + nested finally for the context ClassLoader restore (ensures close happens after restore, and close exceptions are properly suppressed rather than masking).

Verified locally:

• ./gradlew -p buildSrc formatMain checkstyleMain ✅
• :spring-boot-project:spring-boot:checkArchitectureMainJava (exercises the method) ✅
• DCO clean.

The updated commit is on the branch.

[snicoll]

Thanks @nosan, I had the same thoughts when I had a quick look but I meant to polish in that direction. Thanks @SebTardif for following up.