Close FileOutputStream delegate in InspectingOutputStream#50639
Merged
snicoll merged 1 commit intoMay 31, 2026
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
InspectingOutputStream extends OutputStream but does not override close(). When content exceeds MEMORY_LIMIT (approximately 4 KB), convertToTempFile() replaces the ByteArrayOutputStream delegate with a FileOutputStream. The try-with-resources in InspectedContent.of() calls close(), which inherits the no-op OutputStream.close(), leaving the FileOutputStream open and leaking a file descriptor. Override close() to delegate to the underlying stream. See spring-projectsgh-50639 Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
snicoll
added
type: task
snicoll
force-pushed
the
close-inspecting-output-stream
branch
from
d65e645 to
eaf4a0a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InspectingOutputStreamextendsOutputStreambut does not overrideclose(). When content exceedsMEMORY_LIMIT(approximately 4 KB),convertToTempFile()replaces theByteArrayOutputStreamdelegate with aFileOutputStream. The try-with-resources inInspectedContent.of()callsclose(), which inherits the no-opOutputStream.close(), leaving theFileOutputStreamopen and leaking a file descriptor.This commit overrides
close()to delegate to the underlying stream.