Honor include-overall-health in gRPC health#50799
Open
xfocus3 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Ahmed El amraouiyine <amraouiyine@gmail.com>
spring-projects-issues
added
the
status: waiting-for-triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes gh-50791
spring.grpc.server.health.include-overall-health=falsewas bound but not used by the auto-configured gRPC health components. The overall server component was always created, so scheduled gRPC health updates still evaluated all health contributors even when overall health reporting was disabled.This change makes the auto-configured server component nullable and omits it when overall health reporting is disabled. Service-specific health components continue to be created from
spring.grpc.server.health.service.*settings.Verification:
./gradlew :module:spring-boot-grpc-server:test --tests org.springframework.boot.grpc.server.autoconfigure.health.AutoConfiguredHealthCheckedGrpcComponentsTests.getServerWhenIncludeOverallHealthIsFalseReturnsNull --no-daemonfailed before the fix../gradlew :module:spring-boot-grpc-server:test --tests org.springframework.boot.grpc.server.autoconfigure.health.AutoConfiguredHealthCheckedGrpcComponentsTests.getServerWhenIncludeOverallHealthIsFalseReturnsNull --tests org.springframework.boot.grpc.server.autoconfigure.health.GrpcServerHealthAutoConfigurationTests.whenIncludeOverallHealthIsFalseDoesNotReportOverallHealth --no-daemon./gradlew :module:spring-boot-grpc-server:test --tests org.springframework.boot.grpc.server.autoconfigure.health.AutoConfiguredHealthCheckedGrpcComponentsTests --tests org.springframework.boot.grpc.server.autoconfigure.health.GrpcServerHealthAutoConfigurationTests --no-daemon./gradlew :module:spring-boot-grpc-server:checkstyleMain :module:spring-boot-grpc-server:checkstyleTest --no-daemongit diff --check HEAD^ HEAD