Only configure protobuf gRPC generation for gRPC dependencies#50824
Closed
xfocus3 wants to merge 1 commit into
Closed
Only configure protobuf gRPC generation for gRPC dependencies#50824xfocus3 wants to merge 1 commit into
xfocus3 wants to merge 1 commit into
Conversation
Signed-off-by: Ahmed El amraouiyine <amraouiyine@gmail.com>
Member
|
Thanks for the proposal. Resolving a configuration while configuring a task, even lazily, is to be avoided so we can't apply this fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes gh-50822
Spring Boot's Gradle plugin currently adds the protobuf
grpcplugin to every generate proto task whenever the protobuf plugin is applied. In a protobuf-only build that has no gRPC dependencies, this makesgeneratePrototry to resolveio.grpc:protoc-gen-grpc-java:null.This updates the protobuf plugin reaction so the
grpcplugin is only added to generate proto tasks when a gRPC dependency is declared. Protobuf-only builds still get the managedprotocartifact, while gRPC builds keep the existing@generated=omitconfiguration.Verification:
./gradlew --no-daemon :build-plugin:spring-boot-gradle-plugin:test --tests org.springframework.boot.gradle.plugin.ProtobufPluginActionIntegrationTests./gradlew --no-daemon :build-plugin:spring-boot-gradle-plugin:checkstyleMain :build-plugin:spring-boot-gradle-plugin:checkstyleTestgit diff --check HEAD^ HEAD