Handle missing gRPC server event type in test initializer#50826
Open
xfocus3 wants to merge 3 commits into
Open
Handle missing gRPC server event type in test initializer#50826xfocus3 wants to merge 3 commits into
xfocus3 wants to merge 3 commits into
Conversation
Signed-off-by: Ahmed El amraouiyine <amraouiyine@gmail.com>
added 2 commits
June 23, 2026 18:43
Signed-off-by: Ahmed El amraouiyine <amraouiyine@gmail.com>
Signed-off-by: Ahmed El amraouiyine <amraouiyine@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes gh-50825
spring-boot-starter-test-classiccan includespring-boot-grpc-testwithout the Spring gRPC server classes. The gRPC test initializer currently adds a listener whose generic event type referencesGrpcServerStartedEvent; refreshing any context then asks Spring to resolve the listener event type and fails when that class is not on the classpath.This changes the listener to accept application events and only handle gRPC server-started events by class name. It keeps the existing port-property behavior when Spring gRPC is present and avoids resolving the event type when it is absent.
Verification:
GrpcPortInfoApplicationContextInitializerTests.whenGrpcServerStartedEventIsNotPresentInitializerDoesNotFailOnRefreshfailed before the fix withTypeNotPresentException: Type org.springframework.grpc.server.lifecycle.GrpcServerStartedEvent not present./gradlew --no-daemon :module:spring-boot-grpc-test:test --tests org.springframework.boot.grpc.test.autoconfigure.GrpcPortInfoApplicationContextInitializerTests./gradlew --no-daemon :module:spring-boot-grpc-test:test :module:spring-boot-grpc-test:checkstyleMain :module:spring-boot-grpc-test:checkstyleTestgit diff --check HEAD