Refactor JdbcConnectionDetailsBeanPostProcessor to obtain dataSourceClass from generics#50883
Closed
quaff wants to merge 1 commit into
Closed
Refactor JdbcConnectionDetailsBeanPostProcessor to obtain dataSourceClass from generics#50883quaff wants to merge 1 commit into
quaff wants to merge 1 commit into
Conversation
…lass from generics It make codes more concise, and it's safe to change constructor signature since those classes aren't public API. Signed-off-by: Yanming Zhou <zhouyanming@gmail.com>
spring-projects-issues
added
the
status: waiting-for-triage
Member
|
Thanks, but I don't think that's a problem that we have to provide the value this way. |
snicoll
added
status: declined
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It make codes more concise, and it's safe to change constructor signature since those classes aren't public API.