Fix IS NULL rendering of keyset queries using Querydsl#4275
Closed
stupid58fly wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Ilya Bakaev <stupid58fly@gmail.com>
c1d6378 to
51d8211
Compare
Member
|
Can we have simpler tests, ideally that demonstrate the problem and test the query itself rather than the effect? |
Contributor
Author
I tried to write this test, but didn't succeed. |
IS NULL rendering of keyset queries using Querydsl
mp911de
pushed a commit
that referenced
this pull request
Jul 3, 2026
Signed-off-by: Ilya Bakaev <stupid58fly@gmail.com> Closes #4275
mp911de
added a commit
that referenced
this pull request
Jul 3, 2026
Add test for correct IS NULL rendering in keyset-based scrolling queries. See #4275
mp911de
pushed a commit
that referenced
this pull request
Jul 3, 2026
Signed-off-by: Ilya Bakaev <stupid58fly@gmail.com> Closes #4275
mp911de
added a commit
that referenced
this pull request
Jul 3, 2026
Add test for correct IS NULL rendering in keyset-based scrolling queries. See #4275
mp911de
added a commit
that referenced
this pull request
Jul 3, 2026
Add test for correct IS NULL rendering in keyset-based scrolling queries. See #4275
Member
|
Thank you for your contribution. That's merged, polished, and backported now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue for querydsl scroll where one of keyset position values is null.
Before fix querydsl generates query with
column = nulland after fix it will becolumn is null.