Skip to content

Fix IS NULL rendering of keyset queries using Querydsl#4275

Closed
stupid58fly wants to merge 1 commit into
spring-projects:mainfrom
stupid58fly:bugfix/fix-null-check-for-querydsl-predicate-excecutor
Closed

Fix IS NULL rendering of keyset queries using Querydsl#4275
stupid58fly wants to merge 1 commit into
spring-projects:mainfrom
stupid58fly:bugfix/fix-null-check-for-querydsl-predicate-excecutor

Conversation

@stupid58fly

Copy link
Copy Markdown
Contributor

This PR fixes the issue for querydsl scroll where one of keyset position values is null.
Before fix querydsl generates query with column = null and after fix it will be column is null.

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 5, 2026
Signed-off-by: Ilya Bakaev <stupid58fly@gmail.com>
@stupid58fly stupid58fly force-pushed the bugfix/fix-null-check-for-querydsl-predicate-excecutor branch from c1d6378 to 51d8211 Compare June 5, 2026 16:59
@mp911de

mp911de commented Jun 8, 2026

Copy link
Copy Markdown
Member

Can we have simpler tests, ideally that demonstrate the problem and test the query itself rather than the effect?

@stupid58fly

Copy link
Copy Markdown
Contributor Author

Can we have simpler tests, ideally that demonstrate the problem and test the query itself rather than the effect?

I tried to write this test, but didn't succeed.
There is no such tests for QueryDSL, at least I could not find it.
I have tried to do that, but couldn't find any point to join the query rendering.
Not sure it is possible to implement such test without refactoring QueryDSL implementation.
If you have any suggestions, could you please share?

@mp911de mp911de added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Jun 15, 2026
@mp911de mp911de self-assigned this Jun 15, 2026
@mp911de mp911de changed the title Fix null check for querydsl predicate executor Fix IS NULL rendering of keyset queries using Querydsl Jul 3, 2026
@mp911de mp911de added this to the 4.0.7 (2025.1.7) milestone Jul 3, 2026
mp911de pushed a commit that referenced this pull request Jul 3, 2026
Signed-off-by: Ilya Bakaev <stupid58fly@gmail.com>
Closes #4275
mp911de added a commit that referenced this pull request Jul 3, 2026
Add test for correct IS NULL rendering in keyset-based scrolling queries.

See #4275
mp911de pushed a commit that referenced this pull request Jul 3, 2026
Signed-off-by: Ilya Bakaev <stupid58fly@gmail.com>
Closes #4275
mp911de added a commit that referenced this pull request Jul 3, 2026
Add test for correct IS NULL rendering in keyset-based scrolling queries.

See #4275
@mp911de mp911de closed this in 3710a17 Jul 3, 2026
mp911de added a commit that referenced this pull request Jul 3, 2026
Add test for correct IS NULL rendering in keyset-based scrolling queries.

See #4275
@mp911de

mp911de commented Jul 3, 2026

Copy link
Copy Markdown
Member

Thank you for your contribution. That's merged, polished, and backported now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug A general bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants