Align Jedis restore TTL parameter with long type#3388
Open
DragonFSKY wants to merge 1 commit into
Open
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
DragonFSKY
force-pushed
the
gh-3386-jedis-restore-long-ttl
branch
2 times, most recently
from
d8e01bf to
9d98af1
Compare
Signed-off-by: Dongliang Xie <dragonfsky@gmail.com>
DragonFSKY
force-pushed
the
gh-3386-jedis-restore-long-ttl
branch
from
9d98af1 to
9d212f8
Compare
mp911de
added
type: bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3386.
This aligns the Jedis
RESTOREcommand mapping with thelongTTL parameter exposed by Spring Data Redis and supported by Jedis.Changes:
ttlInMillisthrough aslongfor Jedisrestore, including theREPLACEpath.Integer.MAX_VALUEguard that was only needed when the value was narrowed toint.GH-3386unit coverage for TTL values aboveInteger.MAX_VALUE.Verification:
./mvnw -Dtest=JedisConnectionUnitTests testgit diff --checkYou have read the Spring Data contribution guidelines.
You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
You submit test cases (unit or integration tests) that back your changes.
You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).