Skip to content

Commit 1e843fd

Browse files
committed
Polish contribution
See gh-36777
1 parent 4bb20ea commit 1e843fd

2 files changed

Lines changed: 5 additions & 2 deletions

File tree

spring-webflux/src/main/java/org/springframework/web/reactive/function/client/ExchangeFilterFunctions.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,10 +79,12 @@ public static ExchangeFilterFunction statusError(Predicate<HttpStatusCode> statu
7979
* Return a filter that applies HTTP Basic Authentication to the request
8080
* headers via {@link HttpHeaders#setBasicAuth(String)} and
8181
* {@link HttpHeaders#encodeBasicAuth(String, String, Charset)}.
82-
* <p>{@linkplain StandardCharsets#ISO_8859_1 ISO-8859-1} is used to convert the credentials into an octet sequence.
82+
* <p>{@linkplain StandardCharsets#ISO_8859_1 ISO-8859-1} is used to convert
83+
* the credentials into an octet sequence.
8384
* @param username the username
8485
* @param password the password
8586
* @return the filter to add authentication headers with
87+
* @see #basicAuthentication(String, String, Charset)
8688
* @see HttpHeaders#encodeBasicAuth(String, String, Charset)
8789
* @see HttpHeaders#setBasicAuth(String)
8890
*/
@@ -100,6 +102,7 @@ public static ExchangeFilterFunction basicAuthentication(String username, String
100102
* sequence. Defaults to {@linkplain StandardCharsets#ISO_8859_1 ISO-8859-1}.
101103
* @return the filter to add authentication headers with
102104
* @since 7.0.8
105+
* @see #basicAuthentication(String, String)
103106
* @see HttpHeaders#encodeBasicAuth(String, String, Charset)
104107
* @see HttpHeaders#setBasicAuth(String)
105108
*/

spring-webflux/src/test/java/org/springframework/web/reactive/function/client/ExchangeFilterFunctionsTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ void basicAuthenticationUsernamePassword() {
115115
assertThat(result).isEqualTo(response);
116116
}
117117

118-
@Test
118+
@Test // gh-36777
119119
void basicAuthenticationUsernameAndUnicodePassword() {
120120
ClientRequest request = ClientRequest.create(HttpMethod.GET, DEFAULT_URL).build();
121121
ClientResponse response = mock();

0 commit comments

Comments
 (0)