Skip to content

Commit 21fd589

Browse files
VahidRamezaniDBonobc
authored andcommitted
Make messages in requireNonNull more descriptive
Updates usages of `Objects.requireNonNull` by adding some context to the message so that users get a decent error message back rather than an empty NullPointerException. Signed-off-by: Vahid Ramezani <vahid.ramezani.2014@gmail.com>
1 parent 3647bb3 commit 21fd589

5 files changed

Lines changed: 8 additions & 8 deletions

File tree

spring-grpc-core/src/main/java/org/springframework/grpc/client/interceptor/DefaultDeadlineSetupClientInterceptor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ public class DefaultDeadlineSetupClientInterceptor implements ClientInterceptor
3737
private final Duration defaultDeadline;
3838

3939
public DefaultDeadlineSetupClientInterceptor(Duration defaultDeadline) {
40-
this.defaultDeadline = requireNonNull(defaultDeadline, "defaultDeadline");
40+
this.defaultDeadline = requireNonNull(defaultDeadline, "defaultDeadline must not be null");
4141
}
4242

4343
@Override

spring-grpc-core/src/main/java/org/springframework/grpc/server/DefaultGrpcServerFactory.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ public class DefaultGrpcServerFactory<T extends ServerBuilder<T>> implements Grp
7878

7979
public DefaultGrpcServerFactory(String address, List<ServerBuilderCustomizer<T>> serverBuilderCustomizers) {
8080
this.address = address;
81-
this.serverBuilderCustomizers = Objects.requireNonNull(serverBuilderCustomizers, "serverBuilderCustomizers");
81+
this.serverBuilderCustomizers = Objects.requireNonNull(serverBuilderCustomizers, "serverBuilderCustomizers must not be null");
8282
}
8383

8484
public DefaultGrpcServerFactory(String address, List<ServerBuilderCustomizer<T>> serverBuilderCustomizers,

spring-grpc-core/src/main/java/org/springframework/grpc/server/lifecycle/GrpcServerLifecycle.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,8 @@ public class GrpcServerLifecycle implements SmartLifecycle {
6161
*/
6262
public GrpcServerLifecycle(GrpcServerFactory factory, Duration shutdownGracePeriod,
6363
ApplicationEventPublisher eventPublisher) {
64-
this.factory = requireNonNull(factory, "factory");
65-
this.shutdownGracePeriod = requireNonNull(shutdownGracePeriod, "shutdownGracePeriod");
64+
this.factory = requireNonNull(factory, "factory must not be null");
65+
this.shutdownGracePeriod = requireNonNull(shutdownGracePeriod, "shutdownGracePeriod must not be null");
6666
this.eventPublisher = eventPublisher;
6767
}
6868

spring-grpc-core/src/main/java/org/springframework/grpc/server/lifecycle/GrpcServerLifecycleEvent.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ public abstract class GrpcServerLifecycleEvent extends ApplicationEvent {
4343
*/
4444
protected GrpcServerLifecycleEvent(final GrpcServerLifecycle lifecyle, final Clock clock, final Server server) {
4545
super(lifecyle, clock);
46-
this.server = requireNonNull(server, "server");
46+
this.server = requireNonNull(server, "server must not be null");
4747
}
4848

4949
/**
@@ -53,7 +53,7 @@ protected GrpcServerLifecycleEvent(final GrpcServerLifecycle lifecyle, final Clo
5353
*/
5454
protected GrpcServerLifecycleEvent(final GrpcServerLifecycle lifecyle, final Server server) {
5555
super(lifecyle);
56-
this.server = requireNonNull(server, "server");
56+
this.server = requireNonNull(server, "server must not be null");
5757
}
5858

5959
/**

spring-grpc-core/src/main/java/org/springframework/grpc/server/lifecycle/GrpcServerStartedEvent.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ public GrpcServerStartedEvent(final GrpcServerLifecycle lifecyle, final Clock cl
4949
final String address, final int port) {
5050

5151
super(lifecyle, clock, server);
52-
this.address = requireNonNull(address, "address");
52+
this.address = requireNonNull(address, "address must not be null");
5353
this.port = port;
5454
}
5555

@@ -65,7 +65,7 @@ public GrpcServerStartedEvent(final GrpcServerLifecycle lifecyle, final Server s
6565
final int port) {
6666

6767
super(lifecyle, server);
68-
this.address = requireNonNull(address, "address");
68+
this.address = requireNonNull(address, "address must not be null");
6969
this.port = port;
7070
}
7171

0 commit comments

Comments
 (0)