make the method setBackOffFunction work for the batch processing as well (backport to the branch 3.3.x)#4467
Open
LeosBitto wants to merge 2 commits into
Open
make the method setBackOffFunction work for the batch processing as well (backport to the branch 3.3.x)#4467LeosBitto wants to merge 2 commits into
LeosBitto wants to merge 2 commits into
Conversation
Signed-off-by: Leos Bitto <leos.bitto@gmail.com>
sobychacko
requested changes
Jun 4, 2026
| * @param resetStateOnExceptionChange true if a different exception thrown during retry should end this method. | ||
| * @return a new exception if resetStateOnExceptionChange was true and a different exception has occurred | ||
| * (retry with a possibly different BackOffExecution is expected if non-null is returned) | ||
| * @since 4.0.7 |
Contributor
There was a problem hiding this comment.
The problem with this is that we have the same method on 4.1.x and there we use the since tag as 4.1.0, which is kind of moot since we are introducing this method all way back to 3.3.x. What do you think?
Contributor
Author
There was a problem hiding this comment.
I have changed it to include the versions with backport. If you agree, the same change should be made to main as well - there should be no need to explicitly mention 4.1.0, because all versions after 4.0.6 contain the change.
Signed-off-by: Leos Bitto <leos.bitto@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of the commit 7c9f5c0 to the branch 3.3.x which does not modify any existing public API. The only addition to the public API is a new overload of the method retryBatch in ErrorHandlingUtils which supports the implementation of a custom BackOffFunction and resetStateOnExceptionChange for the batch processing.