Skip to content

Commit a43e9c9

Browse files
committed
Remove dead publishing and release-notes buildSrc code
Two categories of dead code, both confirmed via exhaustive grep across all workflows/docs/build files -- nothing invokes any of it, old CI or new: - ArtifactoryPlugin, PublishArtifactsPlugin, SpringNexusPublishPlugin, and the tasks/dependencies that only existed to support them (deployArtifacts, finalizeDeployArtifacts, org.jfrog.buildinfo, io.github.gradle-nexus, and the already-unused io.codearte nexus-staging-plugin). Deploys go through publishAllPublicationsToLocalRepository plus ensure-artifacts instead. - GitHubMilestonePlugin/GitHubReleasePlugin/GitHubChangelogPlugin and their DTOs/API classes -- a legacy Gradle-task-based release-notes/ GitHub-release mechanism already superseded by perform-release's GH-Action-based approach (github-changelog-generator + publish-release-notes), which itself was removed from ci.yml along with the rest of release scheduling/launching. Also removes MavenBomPlugin (io.spring.convention.bom), which nothing in this project applies -- the dependencies module uses plain java-platform instead -- and its now-pointless TestKit sample fixture.
1 parent f1e2fbb commit a43e9c9

25 files changed

Lines changed: 0 additions & 1935 deletions

build.gradle

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,7 @@ buildscript {
66
dependencies {
77
classpath "com.github.ben-manes:gradle-versions-plugin:0.53.0"
88
classpath "io.spring.gradle:dependency-management-plugin:1.1.7"
9-
classpath "org.jfrog.buildinfo:build-info-extractor-gradle:4.34.2"
109
classpath 'org.hidetake:gradle-ssh-plugin:2.10.1'
11-
classpath 'io.codearte.gradle.nexus:gradle-nexus-staging-plugin:0.30.0'
1210
classpath "io.spring.javaformat:spring-javaformat-gradle-plugin:$springJavaformatVersion"
1311
}
1412
}
@@ -33,10 +31,6 @@ description = "Spring LDAP"
3331

3432
ext.coreModules = subprojects.findAll { p-> (!p.name.contains("test") && !p.name.contains("sample") && !p.name.contains("sandbox")) || p.name.contains("spring-ldap-test") }
3533

36-
configure(subprojects - coreModules) {
37-
tasks.findByPath("publishArtifacts")?.enabled = false
38-
}
39-
4034
nohttp {
4135
source.exclude "buildSrc/build/**"
4236
}

buildSrc/build.gradle

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -49,18 +49,6 @@ gradlePlugin {
4949
id = "org.springframework.security.sagan"
5050
implementationClass = "org.springframework.gradle.sagan.SaganPlugin"
5151
}
52-
githubMilestone {
53-
id = "org.springframework.github.milestone"
54-
implementationClass = "org.springframework.gradle.github.milestones.GitHubMilestonePlugin"
55-
}
56-
githubChangelog {
57-
id = "org.springframework.github.changelog"
58-
implementationClass = "org.springframework.gradle.github.changelog.GitHubChangelogPlugin"
59-
}
60-
githubRelease {
61-
id = "org.springframework.github.release"
62-
implementationClass = "org.springframework.gradle.github.release.GitHubReleasePlugin"
63-
}
6452
s101 {
6553
id = "s101"
6654
implementationClass = "s101.S101Plugin"
@@ -81,7 +69,6 @@ dependencies {
8169
implementation 'org.yaml:snakeyaml:1.33'
8270
implementation localGroovy()
8371

84-
implementation 'io.github.gradle-nexus:publish-plugin:2.0.0'
8572
implementation 'io.projectreactor:reactor-core:3.8.6'
8673
implementation ('org.gretty:gretty:5.0.2') {
8774
exclude group: 'org.springframework.boot', module: 'spring-boot-loader-tools'
@@ -95,7 +82,6 @@ dependencies {
9582
implementation 'net.sourceforge.htmlunit:htmlunit:2.70.0'
9683
implementation 'org.asciidoctor:asciidoctor-gradle-jvm:4.0.5'
9784
implementation 'org.hidetake:gradle-ssh-plugin:2.10.1'
98-
implementation 'org.jfrog.buildinfo:build-info-extractor-gradle:4.34.2'
9985
implementation 'org.springframework:spring-core:6.2.19'
10086
implementation 'org.sonarsource.scanner.gradle:sonarqube-gradle-plugin:7.1.0.6387'
10187

buildSrc/src/main/groovy/io/spring/gradle/convention/ArtifactoryPlugin.groovy

Lines changed: 0 additions & 45 deletions
This file was deleted.

buildSrc/src/main/groovy/io/spring/gradle/convention/MavenBomPlugin.groovy

Lines changed: 0 additions & 17 deletions
This file was deleted.

buildSrc/src/main/groovy/io/spring/gradle/convention/RootProjectPlugin.groovy

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ import org.gradle.api.Plugin
2121
import org.gradle.api.Project
2222
import org.gradle.api.plugins.BasePlugin
2323
import org.gradle.api.plugins.PluginManager
24-
import org.springframework.gradle.maven.SpringNexusPublishPlugin
2524

2625
class RootProjectPlugin implements Plugin<Project> {
2726

@@ -31,7 +30,6 @@ class RootProjectPlugin implements Plugin<Project> {
3130
pluginManager.apply(BasePlugin)
3231
pluginManager.apply(SchemaPlugin)
3332
pluginManager.apply(NoHttpPlugin)
34-
pluginManager.apply(SpringNexusPublishPlugin)
3533
pluginManager.apply("org.sonarqube")
3634

3735
project.repositories.mavenCentral()
@@ -49,11 +47,6 @@ class RootProjectPlugin implements Plugin<Project> {
4947
property "sonar.links.scm_dev", "https://github.com/spring-projects/${projectName}.git"
5048
}
5149
}
52-
53-
def finalizeDeployArtifacts = project.task("finalizeDeployArtifacts")
54-
if (Utils.isRelease(project) && project.hasProperty("ossrhUsername")) {
55-
finalizeDeployArtifacts.dependsOn project.tasks.closeAndReleaseOssrhStagingRepository
56-
}
5750
}
5851

5952
}

buildSrc/src/main/groovy/io/spring/gradle/convention/SpringModulePlugin.groovy

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -35,12 +35,6 @@ class SpringModulePlugin extends AbstractSpringJavaPlugin {
3535
pluginManager.apply(SpringMavenPlugin.class);
3636
pluginManager.apply("io.spring.convention.jacoco");
3737

38-
def deployArtifacts = project.task("deployArtifacts")
39-
deployArtifacts.group = 'Deploy tasks'
40-
deployArtifacts.description = "Deploys the artifacts to either Artifactory or Maven Central"
41-
if (!Utils.isRelease(project)) {
42-
deployArtifacts.dependsOn project.tasks.artifactoryPublish
43-
}
4438
project.tasks.withType(Jar) {
4539
from(project.rootProject.files('LICENSE.txt')) {
4640
into('META-INF')

buildSrc/src/main/java/org/springframework/gradle/github/RepositoryRef.java

Lines changed: 0 additions & 65 deletions
This file was deleted.

buildSrc/src/main/java/org/springframework/gradle/github/changelog/GitHubChangelogPlugin.java

Lines changed: 0 additions & 103 deletions
This file was deleted.

0 commit comments

Comments
 (0)