Skip to content

Commit f3656b4

Browse files
committed
Ensure saml_request in Tests
Issue gh-17823 Signed-off-by: Josh Cummings <3627351+jzheaux@users.noreply.github.com>
1 parent 8f22fd4 commit f3656b4

1 file changed

Lines changed: 6 additions & 0 deletions

File tree

saml2/saml2-service-provider/src/opensaml5Test/java/org/springframework/security/saml2/provider/service/authentication/logout/OpenSaml5LogoutResponseValidatorTests.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@ public void handleWhenAuthenticatedThenHandles() {
5151
RelyingPartyRegistration registration = signing(verifying(registration())).build();
5252
Saml2LogoutRequest logoutRequest = Saml2LogoutRequest.withRelyingPartyRegistration(registration)
5353
.id("id")
54+
.samlRequest("logout_request")
5455
.build();
5556
LogoutResponse logoutResponse = TestOpenSamlObjects.assertingPartyLogoutResponse(registration);
5657
sign(logoutResponse, registration);
@@ -67,6 +68,7 @@ public void handleWhenRedirectBindingThenValidatesSignatureParameter() {
6768
.build();
6869
Saml2LogoutRequest logoutRequest = Saml2LogoutRequest.withRelyingPartyRegistration(registration)
6970
.id("id")
71+
.samlRequest("logout_request")
7072
.build();
7173
LogoutResponse logoutResponse = TestOpenSamlObjects.assertingPartyLogoutResponse(registration);
7274
Saml2LogoutResponse response = redirect(logoutResponse, registration,
@@ -81,6 +83,7 @@ public void handleWhenInvalidIssuerThenInvalidSignatureError() {
8183
RelyingPartyRegistration registration = registration().build();
8284
Saml2LogoutRequest logoutRequest = Saml2LogoutRequest.withRelyingPartyRegistration(registration)
8385
.id("id")
86+
.samlRequest("logout_request")
8487
.build();
8588
LogoutResponse logoutResponse = TestOpenSamlObjects.assertingPartyLogoutResponse(registration);
8689
logoutResponse.getIssuer().setValue("wrong");
@@ -98,6 +101,7 @@ public void handleWhenMismatchedDestinationThenInvalidDestinationError() {
98101
RelyingPartyRegistration registration = registration().build();
99102
Saml2LogoutRequest logoutRequest = Saml2LogoutRequest.withRelyingPartyRegistration(registration)
100103
.id("id")
104+
.samlRequest("logout_request")
101105
.build();
102106
LogoutResponse logoutResponse = TestOpenSamlObjects.assertingPartyLogoutResponse(registration);
103107
logoutResponse.setDestination("wrong");
@@ -115,6 +119,7 @@ public void handleWhenStatusNotSuccessThenInvalidResponseError() {
115119
RelyingPartyRegistration registration = registration().build();
116120
Saml2LogoutRequest logoutRequest = Saml2LogoutRequest.withRelyingPartyRegistration(registration)
117121
.id("id")
122+
.samlRequest("logout_request")
118123
.build();
119124
LogoutResponse logoutResponse = TestOpenSamlObjects.assertingPartyLogoutResponse(registration);
120125
logoutResponse.getStatus().getStatusCode().setValue(StatusCode.UNKNOWN_PRINCIPAL);
@@ -133,6 +138,7 @@ public void handleWhenLogoutResponseHasLineBreaksThenHandles() {
133138
RelyingPartyRegistration registration = signing(verifying(registration())).build();
134139
Saml2LogoutRequest logoutRequest = Saml2LogoutRequest.withRelyingPartyRegistration(registration)
135140
.id("id")
141+
.samlRequest("logout_request")
136142
.build();
137143
LogoutResponse logoutResponse = TestOpenSamlObjects.assertingPartyLogoutResponse(registration);
138144
sign(logoutResponse, registration);

0 commit comments

Comments
 (0)