Skip to content

Commit f91b5f3

Browse files
Merge pull request #18701 from spring-projects/dependabot/gradle/main/com.nimbusds-oauth2-oidc-sdk-11.33
Bump com.nimbusds:oauth2-oidc-sdk from 11.26.1 to 11.33
2 parents 095cc3b + 5418ab2 commit f91b5f3

3 files changed

Lines changed: 13 additions & 5 deletions

File tree

gradle/libs.versions.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@ ch-qos-logback-logback-classic = "ch.qos.logback:logback-classic:1.5.28"
2020
com-fasterxml-jackson-jackson-bom = "com.fasterxml.jackson:jackson-bom:2.21.0"
2121
com-google-inject-guice = "com.google.inject:guice:3.0"
2222
com-netflix-nebula-nebula-project-plugin = "com.netflix.nebula:nebula-project-plugin:8.2.0"
23-
com-nimbusds-nimbus-jose-jwt = "com.nimbusds:nimbus-jose-jwt:10.4"
24-
com-nimbusds-oauth2-oidc-sdk = "com.nimbusds:oauth2-oidc-sdk:11.26.1"
23+
com-nimbusds-nimbus-jose-jwt = "com.nimbusds:nimbus-jose-jwt:10.6"
24+
com-nimbusds-oauth2-oidc-sdk = "com.nimbusds:oauth2-oidc-sdk:11.33"
2525
com-squareup-okhttp3-mockwebserver = { module = "com.squareup.okhttp3:mockwebserver", version.ref = "com-squareup-okhttp3" }
2626
com-squareup-okhttp3-okhttp = { module = "com.squareup.okhttp3:okhttp", version.ref = "com-squareup-okhttp3" }
2727
com-unboundid-unboundid-ldapsdk = "com.unboundid:unboundid-ldapsdk:7.0.4"

oauth2/oauth2-client/src/main/java/org/springframework/security/oauth2/client/registration/ClientRegistrations.java

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ private ClientRegistrations() {
105105
* @return the {@link ClientRegistration} built from the configuration
106106
*/
107107
public static ClientRegistration.Builder fromOidcConfiguration(Map<String, Object> configuration) {
108-
OIDCProviderMetadata metadata = parse(configuration, OIDCProviderMetadata::parse);
108+
OIDCProviderMetadata metadata = parseInput(configuration, OIDCProviderMetadata::parse);
109109
ClientRegistration.Builder builder = withProviderConfiguration(metadata, metadata.getIssuer().getValue());
110110
builder.jwkSetUri(metadata.getJWKSetURI().toASCIIString());
111111
if (metadata.getUserInfoEndpointURI() != null) {
@@ -292,6 +292,15 @@ private static ClientRegistration.Builder getBuilder(String issuer,
292292
throw new IllegalArgumentException(errorMessage);
293293
}
294294

295+
private static <T> T parseInput(Map<String, Object> body, ThrowingFunction<JSONObject, T, ParseException> parser) {
296+
try {
297+
return parse(body, parser);
298+
}
299+
catch (RuntimeException ex) {
300+
throw new IllegalArgumentException(ex);
301+
}
302+
}
303+
295304
private static <T> T parse(Map<String, Object> body, ThrowingFunction<JSONObject, T, ParseException> parser) {
296305
try {
297306
return parser.apply(new JSONObject(body));

oauth2/oauth2-client/src/test/java/org/springframework/security/oauth2/client/registration/ClientRegistrationsTests.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@
4040
import static org.assertj.core.api.Assertions.assertThatExceptionOfType;
4141
import static org.assertj.core.api.Assertions.assertThatIllegalArgumentException;
4242
import static org.assertj.core.api.Assertions.assertThatIllegalStateException;
43-
import static org.assertj.core.api.Assertions.assertThatNullPointerException;
4443

4544
/**
4645
* @author Rob Winch
@@ -475,7 +474,7 @@ private ClientRegistration.Builder registration(Map<String, Object> configuratio
475474
@Test
476475
public void issuerWhenOidcConfigurationResponseMissingJwksUriThenThrowsIllegalArgumentException() throws Exception {
477476
this.response.remove("jwks_uri");
478-
assertThatNullPointerException().isThrownBy(() -> registration(this.response).build());
477+
assertThatIllegalArgumentException().isThrownBy(() -> registration(this.response).build());
479478
}
480479

481480
@Test

0 commit comments

Comments
 (0)