Enhancements to Authentication#toBuilder#18050
Merged
Merged
Conversation
rwinch
reviewed
Oct 15, 2025
This commit consolidates logic common to applying one authenticaiton to another. Specifically, it will copy the authorities in one authentication into the builder instance of another. Closes spring-projectsgh-18053
Leaving the Builder in Authentication allows authentication implementations to implement Builder without needing to implement BuildableAuthentication. Issue spring-projectsgh-18052
jzheaux
force-pushed
the
builder-enhancements
branch
from
d215dc5 to
21ff768
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves
Authentication#toBuilderto a new sub-interface,BuildableAuthentication. This will improve passivity in the Security 7.0 release for applications that are using custom authentication implementations and relying on those concrete types.Specifically, instead of doing:
You can do:
Additionally, the PR adds
authenticationtoBuilderAuthentication.Builderfor easily application of common merging logic: