Skip to content

Fix spring-security-oauth2-core compiler warnings #18482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rwinch merged 3 commits into from
Jan 12, 2026
Merged

Fix spring-security-oauth2-core compiler warnings #18482

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
83a5047
Fix spring-security-oauth2-core compiler warnings
paulvas Jan 12, 2026
c6950bc
Fix: Enforce compiler warnings in oauth2-core
paulvas Jan 12, 2026
e751d14
Fix: migrate compiler-warnings-error plugin to gradle
paulvas Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions buildSrc/src/main/groovy/compile-warnings-error.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
import org.gradle.api.tasks.compile.JavaCompile
import org.jetbrains.kotlin.gradle.tasks.KotlinCompile

tasks.withType(JavaCompile) {
options.compilerArgs += "-Werror"
}

tasks.withType(KotlinCompile) {
kotlinOptions.allWarningsAsErrors = true
}
4 changes: 4 additions & 0 deletions oauth2/oauth2-core/spring-security-oauth2-core.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
plugins {
id 'compile-warnings-error'
}

apply plugin: 'io.spring.convention.spring-module'

dependencies {
Expand Down
13 changes: 2 additions & 11 deletions ...springframework/security/oauth2/core/web/reactive/function/OAuth2BodyExtractorsTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
package org.springframework.security.oauth2.core.web.reactive.function;

import java.time.Instant;
import java.util.ArrayList;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
Expand All @@ -27,15 +26,11 @@
import org.junit.jupiter.api.Test;
import reactor.core.publisher.Mono;

import org.springframework.core.codec.ByteBufferDecoder;
import org.springframework.core.codec.StringDecoder;
import org.springframework.http.HttpStatus;
import org.springframework.http.MediaType;
import org.springframework.http.ReactiveHttpInputMessage;
import org.springframework.http.codec.DecoderHttpMessageReader;
import org.springframework.http.codec.FormHttpMessageReader;
import org.springframework.http.codec.ClientCodecConfigurer;
import org.springframework.http.codec.HttpMessageReader;
import org.springframework.http.codec.json.Jackson2JsonDecoder;
import org.springframework.http.server.reactive.ServerHttpResponse;
import org.springframework.mock.http.client.reactive.MockClientHttpResponse;
import org.springframework.security.oauth2.core.OAuth2AccessToken;
Expand All @@ -58,11 +53,7 @@ public class OAuth2BodyExtractorsTests {

@BeforeEach
public void createContext() {
final List<HttpMessageReader<?>> messageReaders = new ArrayList<>();
messageReaders.add(new DecoderHttpMessageReader<>(new ByteBufferDecoder()));
messageReaders.add(new DecoderHttpMessageReader<>(StringDecoder.allMimeTypes()));
messageReaders.add(new DecoderHttpMessageReader<>(new Jackson2JsonDecoder()));
messageReaders.add(new FormHttpMessageReader());
List<HttpMessageReader<?>> messageReaders = ClientCodecConfigurer.create().getReaders();
this.hints = new HashMap<>();
this.context = new BodyExtractor.Context() {
@Override
Expand Down
Loading