Enable javadoc-warnings-error for oauth2-resource-server#18504
Merged
Conversation
Closes spring-projectsgh-18463 Signed-off-by: zoo-code <kyj20908@naver.com>
spring-projects-issues
added
the
status: waiting-for-triage
rwinch
added
in: docs
Member
|
Thanks for the Pull Request & congrats on your first PR to Spring Security! This is now merged into main 😄 |
rwinch
added
in: build
Contributor
Author
@rwinch Thank you so much for the warm welcome and for merging my PR! I'm thrilled to make my first contribution to Spring Security. Looking forward to contributing more in the future! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my first contribution to Spring Security!
and my first open source contribution, so there may be many shortcomings.
This PR enables the
javadoc-warnings-errorplugin for thespring-security-oauth2-resource-servermodule as part of gh-18443Changes
javadoc-warnings-errorplugin to fail the build on Javadoc warningsVerification
./gradlew :spring-security-oauth2-resource-server:javadocpasses without warningsthanks!!!
Closes gh-18463