Skip to content

Add missing SAMLResponse to unit test #18638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ngocnhan-tran1996 wants to merge 2 commits into from
Closed

Add missing SAMLResponse to unit test #18638

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d81e6f4
Add missing `SAMLResponse` to unit test
ngocnhan-tran1996 Feb 3, 2026
4517ed5
Polish `Saml2LogoutResponse#Builder`
ngocnhan-tran1996 Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...ramework/security/config/annotation/web/configurers/saml2/Saml2LogoutConfigurerTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,7 +409,9 @@ public void saml2LogoutRequestWhenCustomLogoutRequestHandlerThenUses() throws Ex
logoutRequest.setIssueInstant(Instant.now());
given(getBean(Saml2LogoutRequestValidator.class).validate(any()))
.willReturn(Saml2LogoutValidatorResult.success());
Saml2LogoutResponse logoutResponse = Saml2LogoutResponse.withRelyingPartyRegistration(registration).build();
Saml2LogoutResponse logoutResponse = Saml2LogoutResponse.withRelyingPartyRegistration(registration)
.samlResponse("response")
.build();
given(getBean(Saml2LogoutResponseResolver.class).resolve(any(), any())).willReturn(logoutResponse);
this.mvc.perform(post("/logout/saml2/slo").param("SAMLRequest", "samlRequest").with(authentication(this.user)))
.andReturn();
Expand Down
4 changes: 3 additions & 1 deletion ...t/java/org/springframework/security/config/http/Saml2LogoutBeanDefinitionParserTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,9 @@ public void saml2LogoutRequestWhenCustomLogoutRequestHandlerThenUses() throws Ex
logoutRequest.setIssueInstant(Instant.now());
given(getBean(Saml2LogoutRequestValidator.class).validate(any()))
.willReturn(Saml2LogoutValidatorResult.success());
Saml2LogoutResponse logoutResponse = Saml2LogoutResponse.withRelyingPartyRegistration(registration).build();
Saml2LogoutResponse logoutResponse = Saml2LogoutResponse.withRelyingPartyRegistration(registration)
.samlResponse("response")
.build();
given(getBean(Saml2LogoutResponseResolver.class).resolve(any(), any())).willReturn(logoutResponse);
this.mvc
.perform(post("/logout/saml2/slo").param("SAMLRequest", "samlRequest").with(authentication(this.saml2User)))
Expand Down
2 changes: 1 addition & 1 deletion ...gframework/security/saml2/provider/service/authentication/logout/Saml2LogoutResponse.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ public static final class Builder {

private Saml2MessageBinding binding;

private Map<String, String> parameters = new LinkedHashMap<>();
private final Map<String, String> parameters = new LinkedHashMap<>();

private Function<Map<String, String>, @Nullable String> encoder = DEFAULT_ENCODER;

Expand Down
Loading