Skip to content

Fix : Wrap IllegalStateException as BadJwtException in NimbusJwtDecoder #19032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chanani wants to merge 2 commits into
base: main
Choose a base branch
from
+20 −0
Open

Fix : Wrap IllegalStateException as BadJwtException in NimbusJwtDecoder #19032

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
98b6da1
Fix : Wrap IllegalStateException as BadJwtException in NimbusJwtDecoder
chanani Apr 3, 2026
2b8669d
fix : Replace wildcard import with explicit imports in NimbusJwtDecod…
chanani Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...2/oauth2-jose/src/main/java/org/springframework/security/oauth2/jwt/NimbusJwtDecoder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,10 @@ private Jwt createJwt(String token, JWT parsedJwt) {
this.logger.trace("Failed to process JWT", ex);
throw new JwtException(String.format(DECODING_ERROR_MESSAGE_TEMPLATE, ex.getMessage()), ex);
}
catch (IllegalStateException ex) {
this.logger.trace("Failed to validate issuer", ex);
throw new BadJwtException(String.format(DECODING_ERROR_MESSAGE_TEMPLATE, ex.getMessage()), ex);
}
catch (Exception ex) {
this.logger.trace("Failed to process JWT", ex);
if (ex.getCause() instanceof ParseException) {
Expand Down
16 changes: 16 additions & 0 deletions ...th2-jose/src/test/java/org/springframework/security/oauth2/jwt/NimbusJwtDecoderTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@
import com.nimbusds.jose.proc.JWSKeySelector;
import com.nimbusds.jose.proc.JWSVerificationKeySelector;
import com.nimbusds.jose.proc.SecurityContext;
import com.nimbusds.jwt.JWT;
import com.nimbusds.jwt.JWTClaimsSet;
import com.nimbusds.jwt.SignedJWT;
import com.nimbusds.jwt.proc.BadJWTException;
Expand Down Expand Up @@ -82,6 +83,7 @@
import static org.assertj.core.api.Assertions.assertThatIllegalStateException;
import static org.mockito.ArgumentMatchers.any;
import static org.mockito.ArgumentMatchers.eq;
import static org.mockito.ArgumentMatchers.isNull;
import static org.mockito.BDDMockito.given;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.times;
Expand Down Expand Up @@ -879,6 +881,20 @@ public void decodeWhenSecretKeyValidateTypeFalseThenSkipsNimbusTypeValidation()
jwtDecoder.decode(jwt.serialize());
}

// gh-18388
@Test
public void decodeWhenIllegalStateExceptionThenThrowsBadJwtException() throws Exception {
JWTProcessor<SecurityContext> jwtProcessor = mock(JWTProcessor.class);
given(jwtProcessor.process(any(JWT.class), isNull())).willThrow(new IllegalStateException());
NimbusJwtDecoder jwtDecoder = new NimbusJwtDecoder(jwtProcessor);
// @formatter:off
assertThatExceptionOfType(BadJwtException.class)
.isThrownBy(() -> jwtDecoder.decode(SIGNED_JWT))
.withCauseInstanceOf(IllegalStateException.class)
.withMessageContaining("An error occurred while attempting to decode the Jwt");
// @formatter:on
}

private RSAPublicKey key() throws InvalidKeySpecException {
byte[] decoded = Base64.getDecoder().decode(VERIFY_KEY.getBytes());
EncodedKeySpec spec = new X509EncodedKeySpec(decoded);
Expand Down
Loading