diff --git a/core/src/main/java/org/springframework/security/access/expression/AbstractSecurityExpressionHandler.java b/core/src/main/java/org/springframework/security/access/expression/AbstractSecurityExpressionHandler.java index 79ef23a117b..eaae28f93ac 100644 --- a/core/src/main/java/org/springframework/security/access/expression/AbstractSecurityExpressionHandler.java +++ b/core/src/main/java/org/springframework/security/access/expression/AbstractSecurityExpressionHandler.java @@ -78,9 +78,7 @@ public final void setExpressionParser(ExpressionParser expressionParser) { public final EvaluationContext createEvaluationContext(@Nullable Authentication authentication, T invocation) { SecurityExpressionOperations root = createSecurityExpressionRoot(authentication, invocation); StandardEvaluationContext ctx = createEvaluationContextInternal(authentication, invocation); - if (this.beanResolver != null) { - ctx.setBeanResolver(this.beanResolver); - } + ctx.setBeanResolver(this.beanResolver); ctx.setRootObject(root); return ctx; } diff --git a/core/src/main/java/org/springframework/security/access/expression/method/DefaultMethodSecurityExpressionHandler.java b/core/src/main/java/org/springframework/security/access/expression/method/DefaultMethodSecurityExpressionHandler.java index 840dc090db4..256cdad189f 100644 --- a/core/src/main/java/org/springframework/security/access/expression/method/DefaultMethodSecurityExpressionHandler.java +++ b/core/src/main/java/org/springframework/security/access/expression/method/DefaultMethodSecurityExpressionHandler.java @@ -23,7 +23,6 @@ import java.util.LinkedHashMap; import java.util.List; import java.util.Map; -import java.util.Optional; import java.util.function.Supplier; import java.util.stream.Stream; @@ -95,7 +94,7 @@ public EvaluationContext createEvaluationContext(Supplier message) { MessageSecurityExpressionRoot root = createSecurityExpressionRoot(authentication, message); StandardEvaluationContext ctx = new StandardEvaluationContext(root); - BeanResolver beanResolver = getBeanResolver(); - if (beanResolver != null) { - // https://github.com/spring-projects/spring-framework/issues/35371 - ctx.setBeanResolver(beanResolver); - } + ctx.setBeanResolver(getBeanResolver()); return ctx; } diff --git a/messaging/src/main/java/org/springframework/security/messaging/handler/invocation/reactive/CurrentSecurityContextArgumentResolver.java b/messaging/src/main/java/org/springframework/security/messaging/handler/invocation/reactive/CurrentSecurityContextArgumentResolver.java index 08044827ea7..be64352f47d 100644 --- a/messaging/src/main/java/org/springframework/security/messaging/handler/invocation/reactive/CurrentSecurityContextArgumentResolver.java +++ b/messaging/src/main/java/org/springframework/security/messaging/handler/invocation/reactive/CurrentSecurityContextArgumentResolver.java @@ -175,10 +175,7 @@ public Mono resolveArgument(MethodParameter parameter, Message messag StandardEvaluationContext context = new StandardEvaluationContext(); context.setRootObject(securityContext); context.setVariable("this", securityContext); - if (this.beanResolver != null) { - // https://github.com/spring-projects/spring-framework/issues/35371 - context.setBeanResolver(this.beanResolver); - } + context.setBeanResolver(this.beanResolver); Expression expression = this.parser.parseExpression(expressionToParse); securityContext = expression.getValue(context); } diff --git a/web/src/main/java/org/springframework/security/web/access/expression/DefaultHttpSecurityExpressionHandler.java b/web/src/main/java/org/springframework/security/web/access/expression/DefaultHttpSecurityExpressionHandler.java index 43cfa949310..0493693edc3 100644 --- a/web/src/main/java/org/springframework/security/web/access/expression/DefaultHttpSecurityExpressionHandler.java +++ b/web/src/main/java/org/springframework/security/web/access/expression/DefaultHttpSecurityExpressionHandler.java @@ -48,7 +48,6 @@ public class DefaultHttpSecurityExpressionHandler extends AbstractSecurityExpres private String defaultRolePrefix = DEFAULT_ROLE_PREFIX; @Override - @SuppressWarnings("NullAway") // https://github.com/spring-projects/spring-framework/issues/35371 public EvaluationContext createEvaluationContext(Supplier authentication, RequestAuthorizationContext context) { WebSecurityExpressionRoot root = createSecurityExpressionRoot(authentication, context); diff --git a/web/src/main/java/org/springframework/security/web/method/annotation/AuthenticationPrincipalArgumentResolver.java b/web/src/main/java/org/springframework/security/web/method/annotation/AuthenticationPrincipalArgumentResolver.java index bdc8b8859ed..2b4d9ec42e2 100644 --- a/web/src/main/java/org/springframework/security/web/method/annotation/AuthenticationPrincipalArgumentResolver.java +++ b/web/src/main/java/org/springframework/security/web/method/annotation/AuthenticationPrincipalArgumentResolver.java @@ -126,10 +126,7 @@ public final class AuthenticationPrincipalArgumentResolver implements HandlerMet StandardEvaluationContext context = new StandardEvaluationContext(); context.setRootObject(principal); context.setVariable("this", principal); - // https://github.com/spring-projects/spring-framework/issues/35371 - if (this.beanResolver != null) { - context.setBeanResolver(this.beanResolver); - } + context.setBeanResolver(this.beanResolver); Expression expression = this.parser.parseExpression(expressionToParse); principal = expression.getValue(context); } diff --git a/web/src/main/java/org/springframework/security/web/method/annotation/CurrentSecurityContextArgumentResolver.java b/web/src/main/java/org/springframework/security/web/method/annotation/CurrentSecurityContextArgumentResolver.java index 23b89bd09b9..bc915ffcef5 100644 --- a/web/src/main/java/org/springframework/security/web/method/annotation/CurrentSecurityContextArgumentResolver.java +++ b/web/src/main/java/org/springframework/security/web/method/annotation/CurrentSecurityContextArgumentResolver.java @@ -160,10 +160,7 @@ public void setTemplateDefaults(AnnotationTemplateExpressionDefaults templateDef StandardEvaluationContext context = new StandardEvaluationContext(); context.setRootObject(securityContext); context.setVariable("this", securityContext); - // https://github.com/spring-projects/spring-framework/issues/35371 - if (this.beanResolver != null) { - context.setBeanResolver(this.beanResolver); - } + context.setBeanResolver(this.beanResolver); Expression expression = this.parser.parseExpression(expressionToParse); securityContextResult = expression.getValue(context); } diff --git a/web/src/main/java/org/springframework/security/web/reactive/result/method/annotation/AuthenticationPrincipalArgumentResolver.java b/web/src/main/java/org/springframework/security/web/reactive/result/method/annotation/AuthenticationPrincipalArgumentResolver.java index 1ef38b32ead..f004c7cf68e 100644 --- a/web/src/main/java/org/springframework/security/web/reactive/result/method/annotation/AuthenticationPrincipalArgumentResolver.java +++ b/web/src/main/java/org/springframework/security/web/reactive/result/method/annotation/AuthenticationPrincipalArgumentResolver.java @@ -95,7 +95,6 @@ public Mono resolveArgument(MethodParameter parameter, BindingContext bi }); } - @SuppressWarnings("NullAway") // https://github.com/spring-projects/spring-framework/issues/35371 private @Nullable Object resolvePrincipal(MethodParameter parameter, @Nullable Object principal) { AuthenticationPrincipal annotation = findMethodAnnotation(parameter); if (annotation == null) { diff --git a/web/src/main/java/org/springframework/security/web/reactive/result/method/annotation/CurrentSecurityContextArgumentResolver.java b/web/src/main/java/org/springframework/security/web/reactive/result/method/annotation/CurrentSecurityContextArgumentResolver.java index c085b579325..f3b2950f034 100644 --- a/web/src/main/java/org/springframework/security/web/reactive/result/method/annotation/CurrentSecurityContextArgumentResolver.java +++ b/web/src/main/java/org/springframework/security/web/reactive/result/method/annotation/CurrentSecurityContextArgumentResolver.java @@ -141,7 +141,6 @@ public Mono resolveArgument(MethodParameter parameter, BindingContext bi return securityContext; } - @SuppressWarnings("NullAway") // https://github.com/spring-projects/spring-framework/issues/35371 private @Nullable Object resolveSecurityContextFromAnnotation(CurrentSecurityContext annotation, MethodParameter parameter, Object securityContext) { Object securityContextResult = securityContext;